fix_admin_sales_api

Author: YogeshSharma0201

app/api/admin_sales/events.py

@@ -2,6 +2,7 @@
 from marshmallow_jsonapi.flask import Schema
 from flask_rest_jsonapi import ResourceList
 
+from app.api.helpers.utilities import dasherize
 from app.api.bootstrap import api
 from app.models import db
 from app.models.event import Event
@@ -23,6 +24,7 @@ class AdminSalesByEventsSchema(Schema):
     class Meta:
         type_ = 'admin-sales-by-events'
         self_view = 'v1.admin_sales_by_events'
+        inflect = dasherize
 
     id = fields.String()
     name = fields.String()

app/api/admin_sales/locations.py

@@ -2,6 +2,7 @@
 from marshmallow_jsonapi.flask import Schema
 from flask_rest_jsonapi import ResourceList
 from sqlalchemy import func
+from app.api.helpers.utilities import dasherize
 
 from app.api.bootstrap import api
 from app.models import db
@@ -34,6 +35,7 @@ class AdminSalesByLocationSchema(Schema):
     class Meta:
         type_ = 'admin-sales-by-location'
         self_view = 'v1.admin_sales_by_location'
+        inflect = dasherize
 
     id = fields.String()
     location_name = fields.String()
@@ -63,9 +65,12 @@ class AdminSalesByLocationList(ResourceList):
     """
 
     def query(self, _):
-        locations = self.session.query(Event.location_name) \
-                                .group_by(Event.location_name) \
-                                .cte()
+        locations = self.session.query(
+            Event.location_name,
+            Event.location_name.label('id')) \
+                .group_by(Event.location_name) \
+                .filter(Event.location_name.isnot(None)) \
+                .cte()
 
         pending = sales_per_location_by_status('pending')
         completed = sales_per_location_by_status('completed')

app/api/admin_sales/organizer.py

@@ -2,6 +2,7 @@
 from marshmallow_jsonapi.flask import Schema
 from flask_rest_jsonapi import ResourceList
 
+from app.api.helpers.utilities import dasherize
 from app.api.bootstrap import api
 from app.models import db
 from app.models.event import Event
@@ -25,6 +26,7 @@ class AdminSalesByOrganizersSchema(Schema):
     class Meta:
         type_ = 'admin-sales-by-organizers'
         self_view = 'v1.admin_sales_by_organizers'
+        inflect = dasherize
 
     id = fields.String()
     first_name = fields.String()

app/api/admin_sales/utils.py

@@ -11,7 +11,7 @@ def status_summary(orders, status):
     """
     return {
         'sales_total': sum([o.amount for o in orders if o.status == status]),
-        'ticket_count': sum([o.tickets_count for o in orders])
+        'ticket_count': sum([o.tickets_count for o in orders if o.status == status])
     }