Skip to content

Conversation

@Leslie-Wong-H
Copy link
Member

Fixes #8675

Short description of what this resolves:

To fix the low efficiency of mobile sessions list lazyload that Eventyay users have suffered for a long time.

Changes proposed in this pull request:

  • Add unique keys to for loop rendering to ensure the correct reconciliation.

Before:

After:

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented May 23, 2023

Deployment failed with the following error:

Resource is limited - try again in 2 hours (more than 100, code: "api-deployments-free-per-day").

@vercel
Copy link

vercel bot commented May 23, 2023

Deployment failed with the following error:

Resource is limited - try again in 1 hour (more than 100, code: "api-deployments-free-per-day").

@cweitat cweitat self-requested a review May 23, 2023 05:22
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7aa3022) 18.71% compared to head (0eb6df9) 18.71%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #8721   +/-   ##
============================================
  Coverage        18.71%   18.71%           
============================================
  Files              621      621           
  Lines             7589     7589           
  Branches           155      155           
============================================
  Hits              1420     1420           
  Misses            6141     6141           
  Partials            28       28           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cweitat cweitat merged commit 8c546f5 into fossasia:development May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile Screen Schedule often refreshes, issues from lazy loading

2 participants