Skip to content

Conversation

@souleb
Copy link
Member

@souleb souleb commented Jun 28, 2022

fixes #787

If implemented, the oci registry client is created with cache disabled.

Depends on: helm/helm#11086

Signed-off-by: Soule BA [email protected]

@souleb souleb marked this pull request as draft June 28, 2022 06:58
@souleb souleb added area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Jun 28, 2022
@souleb souleb changed the title disable cache in oci registry client [Helm]disable cache in oci registry client Jun 28, 2022
@hiddeco hiddeco changed the title [Helm]disable cache in oci registry client [Helm] disable cache in oci registry client Jun 28, 2022
@hiddeco hiddeco changed the title [Helm] disable cache in oci registry client [helm-oci] disable cache in oci registry client Jun 28, 2022
@souleb
Copy link
Member Author

souleb commented Jun 28, 2022

github.com/fluxcd/pkg/helmtestserver has to be downgraded to v0.7.2 to work. Otherwise we need to update it first I think.

@souleb souleb marked this pull request as ready for review June 28, 2022 20:15
@darkowlzz
Copy link
Contributor

@souleb can you rebase please.

If implemented, the oci registry client is created with cache disabled.

Signed-off-by: Soule BA <[email protected]>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb 🥇

@stefanprodan stefanprodan merged commit 5356f72 into fluxcd:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[helm-oci] ECR auth expires

3 participants