registerFactoryParam does not allow List<whatever> params

[spiritinlife]

It seems that providing a List of a class does not work with registerFactoryParam.
There error shown is

Incompatible Type passed as param1
expected: List<FilterBucket> actual: List<FilterBucket>
'package:get_it/get_it_impl.dart':
Failed assertion: line 108 pos 17: 'param1 == null || param1.runtimeType == param1Type'
4:36

version: 4.0.1

[thanhnamitit]

I got the same error, seems this one is not work with built_value too

[votruk]

Yeah, I've tried this new feature too and can confirm that you cannot pass BuiltValue classes as params.

But everything works fine if you replace the following lines in get_it_impl.dart

            assert(
                param1 == null || param1.runtimeType == param1Type,
                'Incompatible Type passed as param1\n'
                'expected: $param1Type actual: ${param1.runtimeType}');
            assert(
                param2 == null || param2.runtimeType == param2Type,
                'Incompatible Type passed as param2\n'
                'expected: $param2Type actual: ${param2.runtimeType}');

with

            assert(
                param1 == null || param1 is P1,
                'Incompatible Type passed as param1\n'
                'expected: $param1Type actual: ${param1.runtimeType}');
            assert(
                param2 == null || param2 is P2,
                'Incompatible Type passed as param2\n'
                'expected: $param2Type actual: ${param2.runtimeType}');

[escamoteur]

@votruk but this isn't what should be checked.

This should check if the passed parameter has the same type as the one the factory was registered with.

[escamoteur]

so I think I will drop this test

[escamoteur]

Should work with the next version