Skip to content

README: uses "effect" instead of "affect" #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardhaven opened this issue Feb 8, 2021 · 6 comments
Closed

README: uses "effect" instead of "affect" #156

richardhaven opened this issue Feb 8, 2021 · 6 comments

Comments

@richardhaven
Copy link

GetIt offers different ways how objects are registered that effect the lifetime of this objects.

Might better be

GetIt offers different ways to register objects, and they each affect the objects' lifespan

@escamoteur
Copy link
Collaborator

Hi,
interesting. It seems it's something that isn't really easy https://www.merriam-webster.com/words-at-play/affect-vs-effect-usage-difference

I think lifetime is the generally used term for objects, but I might be wrong here.

I will change it with the next release. thanks
Thomas

@RahemanAli321
Copy link

Hii, I am interested in open source contribution for flutter so do you any community ?

@escamoteur
Copy link
Collaborator

@RahemanAli321 how do you mean if I do any community?

@RahemanAli321
Copy link

Sorry for bad English I wanted to improve my self and I am trying contribute open source project so that why asked

@escamoteur
Copy link
Collaborator

most package authors are happy about contributions. So if you want to fix a but, or add a feature, open an issue to discuss first, then you can make a PR

@RahemanAli321
Copy link

pull request is good but how can I prepare myself for GSOC i really want to some one who guide me that s why I need community or helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants