Skip to content

Commit 1224988

Browse files
authored
Fix incorrect SwiftPM plugin migration step (#11029)
This was caught by @brianquinlan while migrating the `cupertino_http` plugin. Review URL: https://flutter-docs-prod--pr11029-brian-feedback-9wffzaxo.web.app/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin Part of: dart-lang/http#1276 (comment) ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
1 parent aa44bf2 commit 1224988

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/_includes/docs/swift-package-manager/migrate-objective-c-plugin.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,8 @@ The example below uses `ios`, replace `ios` with `macos`/`darwin` as applicable.
225225
If you would like to use a custom `modulemap` with your Swift package,
226226
refer to [Swift Package Manager's documentation][].
227227
228-
1. Move all remaining files from `ios/Classes` to `ios/Sources/plugin_name`.
228+
1. Move all remaining files from `ios/Classes` to
229+
`ios/plugin_name/Sources/plugin_name`.
229230
230231
1. The `ios/Assets`, `ios/Resources`, and `ios/Classes` directories should now
231232
be empty and can be deleted.

src/_includes/docs/swift-package-manager/migrate-swift-plugin.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ The example below uses `ios`, replace `ios` with `macos`/`darwin` as applicable.
157157
For more instructions, see
158158
[https://developer.apple.com/documentation/xcode/bundling-resources-with-a-swift-package](https://developer.apple.com/documentation/xcode/bundling-resources-with-a-swift-package).
159159

160-
1. Move all files from `ios/Classes` to `ios/Sources/plugin_name`.
160+
1. Move all files from `ios/Classes` to `ios/plugin_name/Sources/plugin_name`.
161161

162162
1. The `ios/Assets`, `ios/Resources`, and `ios/Classes` directories should now
163163
be empty and can be deleted.

0 commit comments

Comments
 (0)