From fbf889c3212654f1cd7927b30680c5f557d75bc3 Mon Sep 17 00:00:00 2001 From: yusufdag Date: Mon, 7 Jun 2021 09:31:53 +0200 Subject: [PATCH 1/3] Fix isMetadataAvailable bool --- .../image_picker/ios/Classes/FLTImagePickerPlugin.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m b/packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m index c4ea34a8128f..e3df6413e9a8 100644 --- a/packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m +++ b/packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m @@ -460,7 +460,7 @@ - (void)imagePickerController:(UIImagePickerController *)picker image = [FLTImagePickerImageUtil scaledImage:image maxWidth:maxWidth maxHeight:maxHeight - isMetadataAvailable:originalAsset != nil]; + isMetadataAvailable:YES]; } if (!originalAsset) { From ed21912bbc3c2cbed9dc7c30c58dcd3cccd8e0a2 Mon Sep 17 00:00:00 2001 From: yusufdag Date: Mon, 7 Jun 2021 09:43:01 +0200 Subject: [PATCH 2/3] Add unit test --- .../example/ios/RunnerTests/ImageUtilTests.m | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/image_picker/image_picker/example/ios/RunnerTests/ImageUtilTests.m b/packages/image_picker/image_picker/example/ios/RunnerTests/ImageUtilTests.m index 54a691d70963..b793d6e1f3e0 100644 --- a/packages/image_picker/image_picker/example/ios/RunnerTests/ImageUtilTests.m +++ b/packages/image_picker/image_picker/example/ios/RunnerTests/ImageUtilTests.m @@ -34,6 +34,16 @@ - (void)testScaledImage_ShouldBeScaledWithNoMetadata { XCTAssertEqual(newImage.size.height, 2); } +- (void)testScaledImage_ShouldBeCorrectRotation { + UIImage *image = [UIImage imageWithData:ImagePickerTestImages.JPGTestData]; + UIImage *newImage = [FLTImagePickerImageUtil scaledImage:image + maxWidth:@3 + maxHeight:@2 + isMetadataAvailable:YES]; + + XCTAssertEqual(newImage.imageOrientation, UIImageOrientationUp); +} + - (void)testScaledGIFImage_ShouldBeScaled { // gif image that frame size is 3 and the duration is 1 second. GIFInfo *info = [FLTImagePickerImageUtil scaledGIFImage:ImagePickerTestImages.GIFTestData From 5f22a42c28728d85eb4c74372ca8969b92abaaeb Mon Sep 17 00:00:00 2001 From: yusufdag Date: Mon, 7 Jun 2021 09:47:40 +0200 Subject: [PATCH 3/3] Update CHANGELOG and version --- packages/image_picker/image_picker/CHANGELOG.md | 4 ++++ packages/image_picker/image_picker/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker/CHANGELOG.md b/packages/image_picker/image_picker/CHANGELOG.md index 703b00bf92a7..e83ab7234a6e 100644 --- a/packages/image_picker/image_picker/CHANGELOG.md +++ b/packages/image_picker/image_picker/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.8.0+2 + +* Fix a rotation problem where when camera is chosen as a source and additional parameters are added. + ## 0.8.0+1 * Removed redundant request for camera permissions. diff --git a/packages/image_picker/image_picker/pubspec.yaml b/packages/image_picker/image_picker/pubspec.yaml index c24fdd01fb1c..4ca29b4d33d1 100755 --- a/packages/image_picker/image_picker/pubspec.yaml +++ b/packages/image_picker/image_picker/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for selecting images from the Android and iOS image library, and taking new pictures with the camera. repository: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22 -version: 0.8.0+1 +version: 0.8.0+2 environment: sdk: ">=2.12.0 <3.0.0"