From 87571442f8fff0478e6f76d785dc97c415730068 Mon Sep 17 00:00:00 2001 From: Dennis Kugelmann Date: Sat, 10 Aug 2019 15:27:19 +0200 Subject: [PATCH 1/3] Fix Future already completed RemoteConfig.instance Fix Future already completed for calling multiple RemoteConfig.instance initially in parallel --- packages/firebase_remote_config/lib/src/remote_config.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/firebase_remote_config/lib/src/remote_config.dart b/packages/firebase_remote_config/lib/src/remote_config.dart index be3912c61dbe..e2867f2f0467 100644 --- a/packages/firebase_remote_config/lib/src/remote_config.dart +++ b/packages/firebase_remote_config/lib/src/remote_config.dart @@ -52,7 +52,9 @@ class RemoteConfig extends ChangeNotifier { instance._remoteConfigSettings = remoteConfigSettings; instance._parameters = _parseRemoteConfigParameters(parameters: properties['parameters']); - _instanceCompleter.complete(instance); + if (!_instanceCompleter.isCompleted) { + _instanceCompleter.complete(instance); + } } static Map _parseRemoteConfigParameters( From ea73a88ddfa5e4fd170856f09d25c3ae1582225d Mon Sep 17 00:00:00 2001 From: Dennis Kugelmann Date: Sat, 10 Aug 2019 15:36:45 +0200 Subject: [PATCH 2/3] Update CHANGELOG.md --- packages/firebase_remote_config/CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/firebase_remote_config/CHANGELOG.md b/packages/firebase_remote_config/CHANGELOG.md index 9d312525f04e..7d8b0a94e10d 100644 --- a/packages/firebase_remote_config/CHANGELOG.md +++ b/packages/firebase_remote_config/CHANGELOG.md @@ -1,3 +1,8 @@ +## 0.1.0+2 + +* Fix `Bad state: Future already completed` error when initially + calling `RemoteConfig.instance` multiple times in parallel. + ## 0.1.0+1 * Log a more detailed warning at build time about the previous AndroidX From cc78a6ff91a285b59b9ccbd8f2fd794f8543f3e1 Mon Sep 17 00:00:00 2001 From: Dennis Kugelmann Date: Sat, 10 Aug 2019 15:37:05 +0200 Subject: [PATCH 3/3] Update pubspec.yaml --- packages/firebase_remote_config/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_remote_config/pubspec.yaml b/packages/firebase_remote_config/pubspec.yaml index 867ff9f46de4..e9dd6074d861 100644 --- a/packages/firebase_remote_config/pubspec.yaml +++ b/packages/firebase_remote_config/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Remote Config. Update your application re-releasing. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_remote_config -version: 0.1.0+1 +version: 0.1.0+2 dependencies: flutter: