From 90585e36e84919af21acc3c02a83c4a71fa7b528 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 7 Mar 2019 14:40:31 -0800 Subject: [PATCH 1/3] Exclude longPress from semantics --- packages/webview_flutter/lib/webview_flutter.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/webview_flutter/lib/webview_flutter.dart b/packages/webview_flutter/lib/webview_flutter.dart index 648f75a33f84..4f0285273df7 100644 --- a/packages/webview_flutter/lib/webview_flutter.dart +++ b/packages/webview_flutter/lib/webview_flutter.dart @@ -153,6 +153,7 @@ class _WebViewState extends State { // handles are not showing. // TODO(amirh): remove this when the issues above are fixed. onLongPress: () {}, + excludeFromSemantics: true, child: AndroidView( viewType: 'plugins.flutter.io/webview', onPlatformViewCreated: _onPlatformViewCreated, From f6429a261548d43b009a85a7738697d14e83713d Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 7 Mar 2019 16:49:02 -0800 Subject: [PATCH 2/3] pubspec changelog --- packages/webview_flutter/CHANGELOG.md | 4 ++++ packages/webview_flutter/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/CHANGELOG.md b/packages/webview_flutter/CHANGELOG.md index 74c8f4d340f4..d1b3dfb06068 100644 --- a/packages/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.3.4 + +* Exclude LongPress handler from semantics tree since it does nothing. + ## 0.3.3+1 * Fixed a memory leak on Android - the WebView was not properly disposed. diff --git a/packages/webview_flutter/pubspec.yaml b/packages/webview_flutter/pubspec.yaml index de8600f8419a..84484a2bcbec 100644 --- a/packages/webview_flutter/pubspec.yaml +++ b/packages/webview_flutter/pubspec.yaml @@ -1,6 +1,6 @@ name: webview_flutter description: A Flutter plugin that provides a WebView widget on Android and iOS. -version: 0.3.3+1 +version: 0.3.4 author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/webview_flutter From 3cb72590f6c023acbc0bb9548563e2a66b3994b8 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 7 Mar 2019 16:54:31 -0800 Subject: [PATCH 3/3] change version to 0.3.3+2 --- packages/webview_flutter/CHANGELOG.md | 2 +- packages/webview_flutter/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webview_flutter/CHANGELOG.md b/packages/webview_flutter/CHANGELOG.md index d1b3dfb06068..889a6a144424 100644 --- a/packages/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/CHANGELOG.md @@ -1,4 +1,4 @@ -## 0.3.4 +## 0.3.3+2 * Exclude LongPress handler from semantics tree since it does nothing. diff --git a/packages/webview_flutter/pubspec.yaml b/packages/webview_flutter/pubspec.yaml index 84484a2bcbec..8307e1fc7206 100644 --- a/packages/webview_flutter/pubspec.yaml +++ b/packages/webview_flutter/pubspec.yaml @@ -1,6 +1,6 @@ name: webview_flutter description: A Flutter plugin that provides a WebView widget on Android and iOS. -version: 0.3.4 +version: 0.3.3+2 author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/webview_flutter