From e794b1240ef69178e36d55a1d544535ff2c061a1 Mon Sep 17 00:00:00 2001
From: Loic Sharma <sharma.loic@gmail.com>
Date: Fri, 23 Feb 2024 13:40:06 -0800
Subject: [PATCH] [Pigeon] Fix tool hangs on verbose sub-processes

---
 .../pigeon/tool/shared/process_utils.dart     | 20 +++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/packages/pigeon/tool/shared/process_utils.dart b/packages/pigeon/tool/shared/process_utils.dart
index 28c816f18b1..e38a4af777f 100644
--- a/packages/pigeon/tool/shared/process_utils.dart
+++ b/packages/pigeon/tool/shared/process_utils.dart
@@ -16,13 +16,29 @@ Future<int> runProcess(String command, List<String> arguments,
     mode:
         streamOutput ? ProcessStartMode.inheritStdio : ProcessStartMode.normal,
   );
+
+  if (streamOutput) {
+    return process.exitCode;
+  }
+
+  final List<int> stdoutBuffer = <int>[];
+  final List<int> stderrBuffer = <int>[];
+  final Future<void> stdoutFuture = process.stdout.forEach(stdoutBuffer.addAll);
+  final Future<void> stderrFuture = process.stderr.forEach(stderrBuffer.addAll);
   final int exitCode = await process.exitCode;
+  await Future.wait(<Future<void>>[
+    stdoutFuture,
+    stderrFuture,
+  ]);
+
   if (exitCode != 0 && logFailure) {
     // ignore: avoid_print
     print('$command $arguments failed:');
+    stdout.add(stdoutBuffer);
+    stderr.add(stderrBuffer);
     await Future.wait(<Future<void>>[
-      process.stdout.pipe(stdout),
-      process.stderr.pipe(stderr),
+      stdout.flush(),
+      stderr.flush(),
     ]);
   }
   return exitCode;