server side issue

[oliviertassinari]

I have noticed the following regression upgrading from 0.8.3 to 0.9.1. We can no longer render the component on the server.

The error comes from this line. As you can imagine, Element isn't defined on Node.js.

https://github.com/souporserious/react-popper/blob/79544d780e33e1e49b9c15d0fa2bf1148641703c/src/Popper.js#L24

[FezVrasta]

Umh that type has not been changed in a while AFAIK... Anyway, are you running the code with the NODE_ENV variable set to production? The types should be stripped in that case.

I understand why it fails, since a Node env doesn't have access to the DOM and so Element is not a thing... But I don't know what's the best way to solve it.

[oliviertassinari]

Umh that type has not been changed in a while AFAIK...

@FezVrasta It was introduced 10 days ago: #92.

Anyway, are you running the code with the NODE_ENV variable set to production?
The types should be stripped in that case.

I'm happy to see the project using my plugin :). But, I'm not running in production. I'm in dev mode.
https://github.com/souporserious/react-popper/blob/79544d780e33e1e49b9c15d0fa2bf1148641703c/package.json#L65

But I don't know what's the best way to solve it.

Me neither. Maybe we can soften the type checking and compare the target with an object. It's what we do on Material-UI side.

[FezVrasta]

Oh I did miss that change, sorry.

Well if we use Object as type I feel like we are just making the type check completely useless honestly 😓 May something like this work? (can you try on your project?)

PropTypes.instanceOf(typeof Element !== 'undefined' ? Element : Object),

[oliviertassinari]

@FezVrasta It's working great on my project 👍

[FezVrasta]

Cool! Would you mind sending a PR with the fix? (maybe with a comment explaining what's going on)