Skip to content

Conversation

@sieniven
Copy link

@sieniven sieniven commented Dec 4, 2025

📝 Summary

Resolves incorrect handling of payload validation for externally built payloads received via the flashblocks p2p after jovian fork.

  1. Previous code makes assumptions that we are on Holoscene fork height, and hardcodes extra data field bytesize.
  2. Incorrect handling of base fee field post jovian fork
  3. Do not handle populating header fields with blob fields

Fixes

  • Adds fork height check to obtain the accurate extra data byte length (on the new Jovian fork, extra data field is length 17)
  • Removes unwrap to prevent builder panic on incorrect byte length when recreating the payload attribute EIP1559 params field
  • Handle pre-Holoscene fork correctly (extra data field and EIP1559 params should be empty)
  • Handle min base fee post jovian fork
  • Align payload validation to default reth's payload validation - add support for populating header fields with blob fields

✅ I have completed the following steps:

  • [✅] Run make lint
  • [✅] Run make test
  • Added tests (if applicable)

@sieniven sieniven marked this pull request as draft December 4, 2025 11:59
* Fix jovian da footprint scalar field

* Fixes
@sieniven sieniven changed the title Fix payload validation error for extra data and eip1559 params on received flashblock from peer builders Fix external flashblock payload validation from p2p builders after jovian fork Dec 4, 2025
@sieniven sieniven marked this pull request as ready for review December 4, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant