diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index f68fbac6..4cd741e4 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -42,19 +42,6 @@ steps: distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" - # Since make test-images mutates the source directory, it cannot be run with other steps. - - wait - - - label: ':linux: build docker images' - commands: - - make test-images - agents: - queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}" - distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" - hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" - - - wait - - label: 'git log validation' command: './.buildkite/logcheck.sh' # This should run in the same queue, but we don't care whether it runs on @@ -131,23 +118,35 @@ steps: distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" - - label: ':hammer: test against firecracker main' - env: - FC_TEST_BIN: "${FC_TEST_DATA_PATH}/firecracker-main" - FC_TEST_JAILER_BIN: "${FC_TEST_DATA_PATH}/jailer-main" - DOCKER_IMAGE_TAG: "$BUILDKITE_BUILD_NUMBER" + - label: 'go mod tidy' commands: - - export FC_TEST_TAP=fc-mst-tap${BUILDKITE_BUILD_NUMBER} - - make test EXTRAGOARGS="-exec 'sudo -E' -v -count=1 -race" DISABLE_ROOT_TESTS= + - 'go mod tidy' + - test -z "$(git status --porcelain)" && exit 0 || git --no-pager diff && echo -e '\ngo.mod and/or go.sum differ from committed, please run "go mod tidy" and commit the updated files.\n' && exit 1 agents: queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}" distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" - - label: 'go mod tidy' + - wait + + - label: ':linux: build Firecracker from the tip of main branch' commands: - - 'go mod tidy' - - test -z "$(git status --porcelain)" && exit 0 || git --no-pager diff && echo -e '\ngo.mod and/or go.sum differ from committed, please run "go mod tidy" and commit the updated files.\n' && exit 1 + - make test-images + agents: + queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}" + distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" + hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}" + + - wait + + - label: ':hammer: test against Firecracker above' + env: + FC_TEST_BIN: "${FC_TEST_DATA_PATH}/firecracker-main" + FC_TEST_JAILER_BIN: "${FC_TEST_DATA_PATH}/jailer-main" + DOCKER_IMAGE_TAG: "$BUILDKITE_BUILD_NUMBER" + commands: + - export FC_TEST_TAP=fc-mst-tap${BUILDKITE_BUILD_NUMBER} + - make test EXTRAGOARGS="-exec 'sudo -E' -v -count=1 -race" DISABLE_ROOT_TESTS= agents: queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}" distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}" diff --git a/Makefile b/Makefile index f0971043..9e2a98e3 100644 --- a/Makefile +++ b/Makefile @@ -139,8 +139,7 @@ $(FIRECRACKER_DIR): test-images: $(FIRECRACKER_BIN) $(JAILER_BIN) $(FIRECRACKER_BIN) $(JAILER_BIN): $(FIRECRACKER_DIR) - $(FIRECRACKER_DIR)/tools/devtool -y build --release && \ - $(FIRECRACKER_DIR)/tools/devtool strip + $(FIRECRACKER_DIR)/tools/devtool -y build --release cp $(FIRECRACKER_DIR)/build/cargo_target/$(FIRECRACKER_TARGET)/release/firecracker $(FIRECRACKER_BIN) cp $(FIRECRACKER_DIR)/build/cargo_target/$(FIRECRACKER_TARGET)/release/jailer $(JAILER_BIN)