Skip to content

Commit 57869b1

Browse files
Remove addVsocksHandler from loadSnapshotHandlerList
According to the firecracker OpenAPI specification [1], creating vsock devices is only a pre-boot request, so adding vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores vsocks anyways. Closes #506 1. https://github.com/firecracker-microvm/firecracker/blob/56aeeac51c00b449a45be4542b3e807d34690ba7/src/api_server/swagger/firecracker.yaml#L676-L678 Signed-off-by: Georgiy Lebedev <[email protected]>
1 parent 4299558 commit 57869b1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

handlers.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,10 @@ var loadSnapshotHandlerList = HandlerList{}.Append(
321321
CreateLogFilesHandler,
322322
BootstrapLoggingHandler,
323323
LoadSnapshotHandler,
324-
AddVsocksHandler,
324+
// According to the firecracker OpenAPI specification, creating vsock devices is only a pre-boot request, so adding
325+
// vsocks after loading a snapshot fails. It also seems redundant, since the VM loaded from a snapshot restores
326+
// vsocks anyways (firecracker-microvm/firecracker-go-sdk#506).
327+
// AddVsocksHandler,
325328
)
326329

327330
var defaultValidationHandlerList = HandlerList{}.Append(

0 commit comments

Comments
 (0)