Skip to content

Commit 21f6a45

Browse files
committed
fixup! Add support for CNI-configured VM network interfaces.
Signed-off-by: Erik Sipsma <[email protected]>
1 parent f1ce526 commit 21f6a45

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

docs/networking.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ message StaticNetworkConfiguration {
154154
message IPConfiguration {
155155
// Network configuration that will be applied to a network interface in a
156156
// Guest VM on boot.
157-
string PrimaryAddr;
158-
string GatewayAddr;
157+
string PrimaryAddress;
158+
string GatewayAddress;
159159
repeated string Nameservers;
160160
}
161161
```

docs/quickstart.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ This quickstart guide provides simple steps to get a working
44
firecracker-containerd environment, with each of the major components built from
55
source. Once you have completed this quickstart, you should be able to run and
66
develop firecracker-containerd (the components in this repository), the
7-
Firecracker VMM, and containerd.
7+
Firecracker VMM, and containerd. Note that the guide below should result in VMs
8+
by default having network access to IPs assigned on the host and may, depending
9+
on the configuration of your host's network, also have outbound access to the
10+
internet.
811

912
This quickstart will clone repositories under your `$HOME` directory and install
1013
files into `/usr/local/bin`.

internal/network_test_utils.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ func (h dnsHandler) ServeDNS(w dns.ResponseWriter, r *dns.Msg) {
141141
Hdr: dns.RR_Header{Name: domain, Rrtype: dns.TypeA, Class: dns.ClassINET, Ttl: 3600},
142142
A: net.ParseIP(address),
143143
})
144+
} else {
145+
msg.SetRcode(r, dns.RcodeNameError)
144146
}
145147
}
146148

0 commit comments

Comments
 (0)