From ea475ca005c683be34a818afa30af5524102d90a Mon Sep 17 00:00:00 2001 From: Marvin Willms <54174311+marvin-kolja@users.noreply.github.com> Date: Tue, 9 Sep 2025 16:02:01 +0200 Subject: [PATCH 1/2] fix: floating promise leading to misleading results --- unit-test-security-rules/test/utils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/unit-test-security-rules/test/utils.ts b/unit-test-security-rules/test/utils.ts index e6ca6e4b..b8c6219c 100644 --- a/unit-test-security-rules/test/utils.ts +++ b/unit-test-security-rules/test/utils.ts @@ -59,7 +59,8 @@ export async function expectFirestorePermissionUpdateSucceeds(promise: Promise) { - expect(assertSucceeds(promise)).not.toBeUndefined(); + const successResult = await assertSucceeds(promise); + expect(successResult).not.toBeUndefined(); } export async function expectDatabasePermissionUpdateSucceeds(promise: Promise) { From 5c5d8eb71f6dd441a3c18fa5dcdcda676b21ccca Mon Sep 17 00:00:00 2001 From: Marvin Willms <54174311+marvin-kolja@users.noreply.github.com> Date: Tue, 9 Sep 2025 16:02:42 +0200 Subject: [PATCH 2/2] fix: floating promise leading to misleading results --- unit-test-security-rules-v9/test/utils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/unit-test-security-rules-v9/test/utils.ts b/unit-test-security-rules-v9/test/utils.ts index ede40edf..81ebfdfa 100644 --- a/unit-test-security-rules-v9/test/utils.ts +++ b/unit-test-security-rules-v9/test/utils.ts @@ -59,7 +59,8 @@ export async function expectFirestorePermissionUpdateSucceeds(promise: Promise) { - expect(assertSucceeds(promise)).not.toBeUndefined(); + const successResult = await assertSucceeds(promise); + expect(successResult).not.toBeUndefined(); } export async function expectDatabasePermissionUpdateSucceeds(promise: Promise) {