Removes experimental warning from ext-install and deploy (#5678)

* Removes experimental warning from ext-install and deploy

* Fix tests

Author: joehan

src/commands/ext-install.ts

@@ -165,13 +165,8 @@ async function infoExtensionVersion(args: {
   extensionVersion: ExtensionVersion;
 }): Promise<void> {
   const ref = refs.parse(args.extensionName);
-  const extension = await extensionsApi.getExtension(refs.toExtensionRef(ref));
   await displayExtInfo(args.extensionName, ref.publisherId, args.extensionVersion.spec, true);
-  await displayWarningPrompts(
-    ref.publisherId,
-    extension.registryLaunchStage,
-    args.extensionVersion
-  );
+  await displayWarningPrompts(ref.publisherId, args.extensionVersion);
 }
 
 interface InstallExtensionOptions {

src/extensions/warnings.ts

@@ -1,13 +1,12 @@
 import { marked } from "marked";
 import * as clc from "colorette";
 
-import { ExtensionVersion, RegistryLaunchStage } from "./types";
+import { ExtensionVersion } from "./types";
 import { printSourceDownloadLink } from "./displayExtensionInfo";
 import { logPrefix } from "./extensionsHelper";
 import { getTrustedPublishers } from "./resolveSource";
 import { humanReadable } from "../deploy/extensions/deploymentSummary";
 import { InstanceSpec, getExtension } from "../deploy/extensions/planner";
-import { partition } from "../functional";
 import * as utils from "../utils";
 import { logger } from "../logger";
 
@@ -30,23 +29,11 @@ function displayEAPWarning({
   printSourceDownloadLink(sourceDownloadUri);
 }
 
-function displayExperimentalWarning() {
-  utils.logLabeledBullet(
-    logPrefix,
-    marked(
-      `${clc.yellow(clc.bold("Important"))}: This extension is ${clc.bold(
-        "experimental"
-      )} and may not be production-ready. Its functionality might change in backward-incompatible ways before its official release, or it may be discontinued.`
-    )
-  );
-}
-
 /**
  * Show warning if extension is experimental or developed by 3P.
  */
 export async function displayWarningPrompts(
   publisherId: string,
-  launchStage: RegistryLaunchStage,
   extensionVersion: ExtensionVersion
 ): Promise<void> {
   const trustedPublishers = await getTrustedPublishers();
@@ -56,8 +43,6 @@ export async function displayWarningPrompts(
       sourceDownloadUri: extensionVersion.sourceDownloadUri,
       githubLink: extensionVersion.spec.sourceUrl,
     });
-  } else if (launchStage === RegistryLaunchStage.EXPERIMENTAL) {
-    displayExperimentalWarning();
   } else {
     // Otherwise, this is an official extension and requires no warning prompts.
     return;
@@ -85,27 +70,9 @@ export async function displayWarningsForDeploy(instancesToCreate: InstanceSpec[]
     await getExtension(i);
   }
 
-  const [eapExtensions, nonEapExtensions] = partition(
-    publishedExtensionInstances,
+  const eapExtensions = publishedExtensionInstances.filter(
     (i) => !trustedPublishers.includes(i.ref?.publisherId ?? "")
   );
-  // Only mark non-eap extensions as experimental.
-  const experimental = nonEapExtensions.filter(
-    (i) => i.extension!.registryLaunchStage === RegistryLaunchStage.EXPERIMENTAL
-  );
-
-  if (experimental.length) {
-    const humanReadableList = experimental.map((i) => `\t${humanReadable(i)}`).join("\n");
-    utils.logLabeledBullet(
-      logPrefix,
-      marked(
-        `The following are instances of ${clc.bold(
-          "experimental"
-        )} extensions.They may not be production-ready. Their functionality may change in backward-incompatible ways before their official release, or they may be discontinued.\n${humanReadableList}\n`,
-        { gfm: false }
-      )
-    );
-  }
 
   if (eapExtensions.length) {
     const humanReadableList = eapExtensions.map(toListEntry).join("\n");
@@ -119,7 +86,7 @@ export async function displayWarningsForDeploy(instancesToCreate: InstanceSpec[]
       )
     );
   }
-  return experimental.length > 0 || eapExtensions.length > 0;
+  return eapExtensions.length > 0;
 }
 
 export function outOfBandChangesWarning(instanceIds: string[]) {

src/test/extensions/warnings.spec.ts

@@ -72,38 +72,18 @@ describe("displayWarningPrompts", () => {
     logLabeledStub.restore();
   });
 
-  it("should not warn if from trusted publisher and not experimental", async () => {
+  it("should not warn if from trusted publisher", async () => {
     const publisherId = "firebase";
 
-    await warnings.displayWarningPrompts(
-      publisherId,
-      RegistryLaunchStage.BETA,
-      testExtensionVersion
-    );
+    await warnings.displayWarningPrompts(publisherId, testExtensionVersion);
 
     expect(logLabeledStub).to.not.have.been.called;
   });
 
-  it("should warn if experimental", async () => {
-    const publisherId = "firebase";
-
-    await warnings.displayWarningPrompts(
-      publisherId,
-      RegistryLaunchStage.EXPERIMENTAL,
-      testExtensionVersion
-    );
-
-    expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "experimental");
-  });
-
   it("should warn if the publisher is not on the approved publisher list", async () => {
     const publisherId = "pubby-mcpublisher";
 
-    await warnings.displayWarningPrompts(
-      publisherId,
-      RegistryLaunchStage.BETA,
-      testExtensionVersion
-    );
+    await warnings.displayWarningPrompts(publisherId, testExtensionVersion);
 
     expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "Early Access Program");
   });
@@ -124,7 +104,7 @@ describe("displayWarningsForDeploy", () => {
     logLabeledStub.restore();
   });
 
-  it("should not warn or prompt if from trusted publisher and not experimental", async () => {
+  it("should not warn or prompt if from trusted publisher", async () => {
     const toCreate = [
       testInstanceSpec("firebase", "ext-id-1", RegistryLaunchStage.GA),
       testInstanceSpec("firebase", "ext-id-2", RegistryLaunchStage.GA),
@@ -136,18 +116,6 @@ describe("displayWarningsForDeploy", () => {
     expect(logLabeledStub).to.not.have.been.called;
   });
 
-  it("should prompt if experimental", async () => {
-    const toCreate = [
-      testInstanceSpec("firebase", "ext-id-1", RegistryLaunchStage.EXPERIMENTAL),
-      testInstanceSpec("firebase", "ext-id-2", RegistryLaunchStage.EXPERIMENTAL),
-    ];
-
-    const warned = await warnings.displayWarningsForDeploy(toCreate);
-
-    expect(warned).to.be.true;
-    expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "experimental");
-  });
-
   it("should prompt if the publisher is not on the approved publisher list", async () => {
     const toCreate = [
       testInstanceSpec("pubby-mcpublisher", "ext-id-1", RegistryLaunchStage.GA),
@@ -159,17 +127,4 @@ describe("displayWarningsForDeploy", () => {
     expect(warned).to.be.true;
     expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "Early Access Program");
   });
-
-  it("should show multiple warnings at once if triggered", async () => {
-    const toCreate = [
-      testInstanceSpec("pubby-mcpublisher", "ext-id-1", RegistryLaunchStage.GA),
-      testInstanceSpec("firebase", "ext-id-2", RegistryLaunchStage.EXPERIMENTAL),
-    ];
-
-    const warned = await warnings.displayWarningsForDeploy(toCreate);
-
-    expect(warned).to.be.true;
-    expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "Early Access Program");
-    expect(logLabeledStub).to.have.been.calledWithMatch("extensions", "experimental");
-  });
 });