From 3156903186a180025222da162cc80127ce8e7e46 Mon Sep 17 00:00:00 2001 From: Navya-arugonda Date: Mon, 6 Oct 2025 11:48:15 -0500 Subject: [PATCH 1/6] fix(auth): export MISSING_PASSWORD in AuthErrorCodes --- packages/auth/src/core/errors.ts | 3 ++- packages/auth/test/node/unit/auth_error_codes.test.ts | 8 ++++++++ packages/auth/tsconfig.json | 6 +++++- 3 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 packages/auth/test/node/unit/auth_error_codes.test.ts diff --git a/packages/auth/src/core/errors.ts b/packages/auth/src/core/errors.ts index 0e7fb53059..3055aad21e 100644 --- a/packages/auth/src/core/errors.ts +++ b/packages/auth/src/core/errors.ts @@ -603,5 +603,6 @@ export const AUTH_ERROR_CODES_MAP_DO_NOT_USE_INTERNALLY = { MISSING_RECAPTCHA_VERSION: 'auth/missing-recaptcha-version', INVALID_RECAPTCHA_VERSION: 'auth/invalid-recaptcha-version', INVALID_REQ_TYPE: 'auth/invalid-req-type', - INVALID_HOSTING_LINK_DOMAIN: 'auth/invalid-hosting-link-domain' + INVALID_HOSTING_LINK_DOMAIN: 'auth/invalid-hosting-link-domain', + MISSING_PASSWORD: 'auth/missing-password' } as const; diff --git a/packages/auth/test/node/unit/auth_error_codes.test.ts b/packages/auth/test/node/unit/auth_error_codes.test.ts new file mode 100644 index 0000000000..e39c7a55b4 --- /dev/null +++ b/packages/auth/test/node/unit/auth_error_codes.test.ts @@ -0,0 +1,8 @@ +import { expect } from 'chai'; +import { AuthErrorCodes } from '../../../src'; + +describe('AuthErrorCodes', () => { + it('exports MISSING_PASSWORD', () => { + expect(AuthErrorCodes.MISSING_PASSWORD).to.equal('auth/missing-password'); + }); +}); diff --git a/packages/auth/tsconfig.json b/packages/auth/tsconfig.json index f8d06916d0..c5855426db 100644 --- a/packages/auth/tsconfig.json +++ b/packages/auth/tsconfig.json @@ -1,7 +1,11 @@ { "extends": "../../config/tsconfig.base.json", "compilerOptions": { - "outDir": "dist" + "outDir": "dist", + "types": ["mocha", "chai"], + "esModuleInterop": true, + "moduleResolution": "node", + "resolveJsonModule": true }, "exclude": ["dist/**/*", "demo/**/*"] } From 92898588098554db62bf1543f05b3d2831f37be8 Mon Sep 17 00:00:00 2001 From: Navya-arugonda Date: Mon, 6 Oct 2025 12:10:30 -0500 Subject: [PATCH 2/6] chore: add patch changeset for @firebase/auth and firebase --- .changeset/metal-lies-compete.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/metal-lies-compete.md diff --git a/.changeset/metal-lies-compete.md b/.changeset/metal-lies-compete.md new file mode 100644 index 0000000000..5a086a9e12 --- /dev/null +++ b/.changeset/metal-lies-compete.md @@ -0,0 +1,6 @@ +--- +'@firebase/auth': patch +'firebase': patch +--- + +Export MISSING_PASSWORD via AuthErrorCodes in @firebase/auth. From 51919b3d0a132f7f1a4dcb8d3912e135d3034949 Mon Sep 17 00:00:00 2001 From: Navya-arugonda Date: Mon, 6 Oct 2025 12:40:06 -0500 Subject: [PATCH 3/6] fix: reorder MISSING_PASSWORD and remove unnecessary test/config changes --- packages/auth/src/core/errors.ts | 4 ++-- packages/auth/test/node/unit/auth_error_codes.test.ts | 8 -------- packages/auth/tsconfig.json | 7 ++----- 3 files changed, 4 insertions(+), 15 deletions(-) delete mode 100644 packages/auth/test/node/unit/auth_error_codes.test.ts diff --git a/packages/auth/src/core/errors.ts b/packages/auth/src/core/errors.ts index 3055aad21e..12c7c87c2b 100644 --- a/packages/auth/src/core/errors.ts +++ b/packages/auth/src/core/errors.ts @@ -560,6 +560,7 @@ export const AUTH_ERROR_CODES_MAP_DO_NOT_USE_INTERNALLY = { MISSING_MFA_INFO: 'auth/missing-multi-factor-info', MISSING_MFA_SESSION: 'auth/missing-multi-factor-session', MISSING_PHONE_NUMBER: 'auth/missing-phone-number', + MISSING_PASSWORD: 'auth/missing-password', MISSING_SESSION_INFO: 'auth/missing-verification-id', MODULE_DESTROYED: 'auth/app-deleted', NEED_CONFIRMATION: 'auth/account-exists-with-different-credential', @@ -603,6 +604,5 @@ export const AUTH_ERROR_CODES_MAP_DO_NOT_USE_INTERNALLY = { MISSING_RECAPTCHA_VERSION: 'auth/missing-recaptcha-version', INVALID_RECAPTCHA_VERSION: 'auth/invalid-recaptcha-version', INVALID_REQ_TYPE: 'auth/invalid-req-type', - INVALID_HOSTING_LINK_DOMAIN: 'auth/invalid-hosting-link-domain', - MISSING_PASSWORD: 'auth/missing-password' + INVALID_HOSTING_LINK_DOMAIN: 'auth/invalid-hosting-link-domain' } as const; diff --git a/packages/auth/test/node/unit/auth_error_codes.test.ts b/packages/auth/test/node/unit/auth_error_codes.test.ts deleted file mode 100644 index e39c7a55b4..0000000000 --- a/packages/auth/test/node/unit/auth_error_codes.test.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { expect } from 'chai'; -import { AuthErrorCodes } from '../../../src'; - -describe('AuthErrorCodes', () => { - it('exports MISSING_PASSWORD', () => { - expect(AuthErrorCodes.MISSING_PASSWORD).to.equal('auth/missing-password'); - }); -}); diff --git a/packages/auth/tsconfig.json b/packages/auth/tsconfig.json index c5855426db..cc0da5556c 100644 --- a/packages/auth/tsconfig.json +++ b/packages/auth/tsconfig.json @@ -1,11 +1,8 @@ { "extends": "../../config/tsconfig.base.json", "compilerOptions": { - "outDir": "dist", - "types": ["mocha", "chai"], - "esModuleInterop": true, - "moduleResolution": "node", - "resolveJsonModule": true + "outDir": "dist" }, + "types": ["jasmine"], "exclude": ["dist/**/*", "demo/**/*"] } From bb8d5909f94d7a2bcfca86e93624d278dadfbff7 Mon Sep 17 00:00:00 2001 From: Navya Sree Arugonda <67328292+Navya-arugonda@users.noreply.github.com> Date: Mon, 6 Oct 2025 18:21:34 +0000 Subject: [PATCH 4/6] docs(auth): update reference for MISSING_PASSWORD export --- docs-devsite/auth.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs-devsite/auth.md b/docs-devsite/auth.md index 1b3938ef4e..97c1205227 100644 --- a/docs-devsite/auth.md +++ b/docs-devsite/auth.md @@ -1914,6 +1914,7 @@ AUTH_ERROR_CODES_MAP_DO_NOT_USE_INTERNALLY: { readonly MISSING_MFA_INFO: "auth/missing-multi-factor-info"; readonly MISSING_MFA_SESSION: "auth/missing-multi-factor-session"; readonly MISSING_PHONE_NUMBER: "auth/missing-phone-number"; + readonly MISSING_PASSWORD: "auth/missing-password"; readonly MISSING_SESSION_INFO: "auth/missing-verification-id"; readonly MODULE_DESTROYED: "auth/app-deleted"; readonly NEED_CONFIRMATION: "auth/account-exists-with-different-credential"; From a032cd8a12a5b132b83b830bcf177f1fe8960aaa Mon Sep 17 00:00:00 2001 From: Navya-arugonda Date: Mon, 6 Oct 2025 13:24:52 -0500 Subject: [PATCH 5/6] chore(auth): revert jasmine types addition --- packages/auth/tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/auth/tsconfig.json b/packages/auth/tsconfig.json index cc0da5556c..f8d06916d0 100644 --- a/packages/auth/tsconfig.json +++ b/packages/auth/tsconfig.json @@ -3,6 +3,5 @@ "compilerOptions": { "outDir": "dist" }, - "types": ["jasmine"], "exclude": ["dist/**/*", "demo/**/*"] } From 174bd83cb2413f5e27f3a695174582d98e0d1d35 Mon Sep 17 00:00:00 2001 From: Navya Sree Arugonda <67328292+Navya-arugonda@users.noreply.github.com> Date: Tue, 7 Oct 2025 15:01:37 +0000 Subject: [PATCH 6/6] chore(auth): update API review --- common/api-review/auth.api.md | 1 + 1 file changed, 1 insertion(+) diff --git a/common/api-review/auth.api.md b/common/api-review/auth.api.md index 0c9625a90e..4253aa36db 100644 --- a/common/api-review/auth.api.md +++ b/common/api-review/auth.api.md @@ -195,6 +195,7 @@ export const AuthErrorCodes: { readonly MISSING_MFA_INFO: "auth/missing-multi-factor-info"; readonly MISSING_MFA_SESSION: "auth/missing-multi-factor-session"; readonly MISSING_PHONE_NUMBER: "auth/missing-phone-number"; + readonly MISSING_PASSWORD: "auth/missing-password"; readonly MISSING_SESSION_INFO: "auth/missing-verification-id"; readonly MODULE_DESTROYED: "auth/app-deleted"; readonly NEED_CONFIRMATION: "auth/account-exists-with-different-credential";