From 33e4c7bcab1fc4056cdd79a13c386d1e72a317b3 Mon Sep 17 00:00:00 2001 From: Wu-Hui Date: Tue, 29 Aug 2023 09:34:48 -0400 Subject: [PATCH 1/4] Fix webchannel wrapper overrides --- packages/webchannel-wrapper/externs/overrides.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/webchannel-wrapper/externs/overrides.js b/packages/webchannel-wrapper/externs/overrides.js index bccac74db64..8aa01e2ae5d 100644 --- a/packages/webchannel-wrapper/externs/overrides.js +++ b/packages/webchannel-wrapper/externs/overrides.js @@ -66,6 +66,9 @@ goog.net.WebChannel.Options.forceLongPolling; /** @type {boolean|undefined} */ goog.net.WebChannel.Options.detectBufferingProxy; +/** @type {boolean|undefined} */ +goog.net.WebChannel.Options.useFetchStreams; + /** @type {unknown} */ goog.net.WebChannel.Options.xmlHttpFactory; From 4896b0db6a4c5e1167daae85ac12a800012dfe2a Mon Sep 17 00:00:00 2001 From: wu-hui <53845758+wu-hui@users.noreply.github.com> Date: Tue, 29 Aug 2023 11:53:26 -0400 Subject: [PATCH 2/4] Create fresh-frogs-heal.md --- .changeset/fresh-frogs-heal.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/fresh-frogs-heal.md diff --git a/.changeset/fresh-frogs-heal.md b/.changeset/fresh-frogs-heal.md new file mode 100644 index 00000000000..56c226c1f74 --- /dev/null +++ b/.changeset/fresh-frogs-heal.md @@ -0,0 +1,6 @@ +--- +"@firebase/firestore": patch +"@firebase/webchannel-wrapper": patch +--- + +Fix webchannel wrapper overrides.js to pick useFetchStreams option. From d60540929ebf7758b9d841197d4380ae467ce9ff Mon Sep 17 00:00:00 2001 From: wu-hui <53845758+wu-hui@users.noreply.github.com> Date: Tue, 29 Aug 2023 12:27:05 -0400 Subject: [PATCH 3/4] Update fresh-frogs-heal.md --- .changeset/fresh-frogs-heal.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fresh-frogs-heal.md b/.changeset/fresh-frogs-heal.md index 56c226c1f74..2cb42b5a4cb 100644 --- a/.changeset/fresh-frogs-heal.md +++ b/.changeset/fresh-frogs-heal.md @@ -3,4 +3,4 @@ "@firebase/webchannel-wrapper": patch --- -Fix webchannel wrapper overrides.js to pick useFetchStreams option. +Fix an [issue](https://github.com/firebase/firebase-js-sdk/issues/7581) where Firestore was incorrectly using XHR instead of fetch for streaming response. From b79801214ebc30a650ad8d5ee46664dbcaaa3fd2 Mon Sep 17 00:00:00 2001 From: wu-hui <53845758+wu-hui@users.noreply.github.com> Date: Tue, 29 Aug 2023 13:13:40 -0400 Subject: [PATCH 4/4] Update fresh-frogs-heal.md --- .changeset/fresh-frogs-heal.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fresh-frogs-heal.md b/.changeset/fresh-frogs-heal.md index 2cb42b5a4cb..7f10a9e7358 100644 --- a/.changeset/fresh-frogs-heal.md +++ b/.changeset/fresh-frogs-heal.md @@ -3,4 +3,4 @@ "@firebase/webchannel-wrapper": patch --- -Fix an [issue](https://github.com/firebase/firebase-js-sdk/issues/7581) where Firestore was incorrectly using XHR instead of fetch for streaming response. +Fix an issue where Firestore was incorrectly using XHR instead of fetch for streaming response.