From 999b0ea0a416b9509b3822749b4dd209319f0cea Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Tue, 4 Nov 2025 11:29:23 -0800 Subject: [PATCH 1/3] Update publisher image to nodejs22. Updates publisher image so we use nodejs22. The previous nodejs20 image we were using were too old, and rolldown (required for new package tooling tsdown) wasn't able to be installed. --- .github/workflows/test.yaml | 4 ++-- scripts/publish-container/Dockerfile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index e87234a60..2b2e666a0 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -17,7 +17,7 @@ jobs: strategy: matrix: node-version: - - 20.x + - 22.x steps: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 @@ -33,7 +33,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20.x + node-version: 22.x cache: npm - run: npm ci - run: npm run build diff --git a/scripts/publish-container/Dockerfile b/scripts/publish-container/Dockerfile index 97f8ad317..f86a74fb4 100644 --- a/scripts/publish-container/Dockerfile +++ b/scripts/publish-container/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20 +FROM node:22 # Install dependencies RUN apt-get update && \ From c54af5f2d95db00bc087ce79f0fabfeae6c6d7e7 Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Tue, 4 Nov 2025 11:31:39 -0800 Subject: [PATCH 2/3] remove optional dep requirement. --- package-lock.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 07c1056fd..7ea419049 100644 --- a/package-lock.json +++ b/package-lock.json @@ -67,9 +67,6 @@ "engines": { "node": ">=18.0.0" }, - "optionalDependencies": { - "@rolldown/binding-linux-x64-gnu": "1.0.0-beta.45" - }, "peerDependencies": { "firebase-admin": "^11.10.0 || ^12.0.0 || ^13.0.0" } @@ -2595,6 +2592,7 @@ "cpu": [ "x64" ], + "dev": true, "license": "MIT", "optional": true, "os": [ From 3b334426d015a854ffa3a49e0fe347355cf4a00a Mon Sep 17 00:00:00 2001 From: Daniel Lee Date: Tue, 4 Nov 2025 11:35:49 -0800 Subject: [PATCH 3/3] actually remove opt dep and specify node version more explicitly --- package.json | 5 +---- scripts/publish-container/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 319159c0a..05ffc7c53 100644 --- a/package.json +++ b/package.json @@ -338,9 +338,6 @@ "express": "^4.21.0", "protobufjs": "^7.2.2" }, - "optionalDependencies": { - "@rolldown/binding-linux-x64-gnu": "1.0.0-beta.45" - }, "devDependencies": { "@eslint/eslintrc": "^3.3.1", "@firebase/api-documenter": "^0.2.0", @@ -393,4 +390,4 @@ "engines": { "node": ">=18.0.0" } -} \ No newline at end of file +} diff --git a/scripts/publish-container/Dockerfile b/scripts/publish-container/Dockerfile index f86a74fb4..435964588 100644 --- a/scripts/publish-container/Dockerfile +++ b/scripts/publish-container/Dockerfile @@ -1,4 +1,4 @@ -FROM node:22 +FROM node:22.21.1 # Install dependencies RUN apt-get update && \