From 30f4b3212f51466044b25af27810a37bd28b66a9 Mon Sep 17 00:00:00 2001 From: Thomas Bouldin Date: Mon, 18 Mar 2024 19:39:55 -0700 Subject: [PATCH 1/2] Remove infinite wrapping of withInit --- src/v1/cloud-functions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v1/cloud-functions.ts b/src/v1/cloud-functions.ts index d5bd3d015..75921ab6f 100644 --- a/src/v1/cloud-functions.ts +++ b/src/v1/cloud-functions.ts @@ -367,6 +367,7 @@ export function makeCloudFunction({ service, triggerResource, }: MakeCloudFunctionArgs): CloudFunction { + handler = withInit(handler); const cloudFunction: any = (data: any, context: any) => { if (legacyEventType && context.eventType === legacyEventType) { /* @@ -404,7 +405,6 @@ export function makeCloudFunction({ context.params = context.params || _makeParams(context, triggerResource); } - handler = withInit(handler); let promise; if (labels && labels["deployment-scheduled"]) { // Scheduled function do not have meaningful data, so exclude it From 5cec90540d5f35d7950d745a4567b571f0758459 Mon Sep 17 00:00:00 2001 From: Thomas Bouldin Date: Tue, 19 Mar 2024 08:30:33 -0700 Subject: [PATCH 2/2] Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e69de29bb..6bacbe4c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -0,0 +1,2 @@ +Fix bug where 1st gen functions eventually fail with stack too deep (#1540) +Make simple CORS options static for improved debugability (#1536)