From 32d96fdee13e282e9c48435903ef81a16a57428b Mon Sep 17 00:00:00 2001 From: Victor Fan Date: Tue, 20 Dec 2022 15:25:27 -0800 Subject: [PATCH 1/2] mark vpc connector as accepting string param type --- src/v1/function-configuration.ts | 2 +- src/v2/options.ts | 2 +- src/v2/providers/alerts/alerts.ts | 2 +- src/v2/providers/alerts/appDistribution.ts | 2 +- src/v2/providers/alerts/crashlytics.ts | 2 +- src/v2/providers/database.ts | 2 +- src/v2/providers/eventarc.ts | 2 +- src/v2/providers/https.ts | 2 +- src/v2/providers/identity.ts | 2 +- src/v2/providers/pubsub.ts | 2 +- src/v2/providers/storage.ts | 2 +- src/v2/providers/tasks.ts | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/v1/function-configuration.ts b/src/v1/function-configuration.ts index e92971a48..12165ce53 100644 --- a/src/v1/function-configuration.ts +++ b/src/v1/function-configuration.ts @@ -205,7 +205,7 @@ export interface RuntimeOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/options.ts b/src/v2/options.ts index 881420bce..caa0638b8 100644 --- a/src/v2/options.ts +++ b/src/v2/options.ts @@ -162,7 +162,7 @@ export interface GlobalOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/alerts/alerts.ts b/src/v2/providers/alerts/alerts.ts index 1826d653a..56a651072 100644 --- a/src/v2/providers/alerts/alerts.ts +++ b/src/v2/providers/alerts/alerts.ts @@ -151,7 +151,7 @@ export interface FirebaseAlertOptions extends options.EventHandlerOptions { * Connect cloud function to specified VPC connector. * A value of null removes the VPC connector */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/alerts/appDistribution.ts b/src/v2/providers/alerts/appDistribution.ts index 117b3f94b..499b50c94 100644 --- a/src/v2/providers/alerts/appDistribution.ts +++ b/src/v2/providers/alerts/appDistribution.ts @@ -165,7 +165,7 @@ export interface AppDistributionOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/alerts/crashlytics.ts b/src/v2/providers/alerts/crashlytics.ts index ee7b69cc2..e6d6d7527 100644 --- a/src/v2/providers/alerts/crashlytics.ts +++ b/src/v2/providers/alerts/crashlytics.ts @@ -245,7 +245,7 @@ export interface CrashlyticsOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts index c88b3b0fe..a5ed34892 100644 --- a/src/v2/providers/database.ts +++ b/src/v2/providers/database.ts @@ -166,7 +166,7 @@ export interface ReferenceOptions extends options.E /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/eventarc.ts b/src/v2/providers/eventarc.ts index ea5e2647f..34c30d8ce 100644 --- a/src/v2/providers/eventarc.ts +++ b/src/v2/providers/eventarc.ts @@ -130,7 +130,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/https.ts b/src/v2/providers/https.ts index 5f046ed1c..eedd42e01 100644 --- a/src/v2/providers/https.ts +++ b/src/v2/providers/https.ts @@ -123,7 +123,7 @@ export interface HttpsOptions extends Omit { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/identity.ts b/src/v2/providers/identity.ts index 5db3c3207..ced3ab5ba 100644 --- a/src/v2/providers/identity.ts +++ b/src/v2/providers/identity.ts @@ -132,7 +132,7 @@ export interface BlockingOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/pubsub.ts b/src/v2/providers/pubsub.ts index f91a640af..dac95a999 100644 --- a/src/v2/providers/pubsub.ts +++ b/src/v2/providers/pubsub.ts @@ -223,7 +223,7 @@ export interface PubSubOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/storage.ts b/src/v2/providers/storage.ts index 70b1ecebd..668538bcb 100644 --- a/src/v2/providers/storage.ts +++ b/src/v2/providers/storage.ts @@ -271,7 +271,7 @@ export interface StorageOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. diff --git a/src/v2/providers/tasks.ts b/src/v2/providers/tasks.ts index c6d446592..dc4ced739 100644 --- a/src/v2/providers/tasks.ts +++ b/src/v2/providers/tasks.ts @@ -128,7 +128,7 @@ export interface TaskQueueOptions extends options.EventHandlerOptions { /** * Connect cloud function to specified VPC connector. */ - vpcConnector?: string | ResetValue; + vpcConnector?: string | Expression | ResetValue; /** * Egress settings for VPC connector. From cb24a949d7446f29872ee3243b803d0c96700978 Mon Sep 17 00:00:00 2001 From: Victor Fan Date: Tue, 27 Dec 2022 10:37:20 -0800 Subject: [PATCH 2/2] add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e69de29bb..d297084f7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -0,0 +1 @@ +- Allow Functions to specify vpcConnector as a string parameter (#1329)