Skip to content

V2 Database triggers. Impossible to override "retry" value #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JR-RomanZaiats opened this issue Jul 5, 2024 · 3 comments · Fixed by #1588
Closed

V2 Database triggers. Impossible to override "retry" value #1584

JR-RomanZaiats opened this issue Jul 5, 2024 · 3 comments · Fixed by #1588

Comments

@JR-RomanZaiats
Copy link

[REQUIRED] Version info

node: v20.11.1

firebase-functions: 4.9.0

firebase-tools: 13.7.4

firebase-admin: 12.0.0

[REQUIRED] Test case

I have investigated that there is no override of "retry" prop for v2->providers->database.js,
meanwhile, firestore.js allows to override it.
image

[REQUIRED] Steps to reproduce

Declare trigger function with such config
image

run npx firebase deploy --only functions:rdbms-testRetryRTDB

after deployment the retry is disabled
image

[REQUIRED] Expected behavior

retry config works properly

[REQUIRED] Actual behavior

retry config is ignored during deployment

@MaxGenash
Copy link

same problem

@MaxGenash
Copy link

@taeold @mbleigh @inlined would be nice if smb could look into it :)

@exaby73
Copy link
Contributor

exaby73 commented Aug 1, 2024

Hey! I've found the issue being that the retry parameter in the functions.yaml config that's sent over to GCP doesn't get populated. I'm working on a fix right now. Sorry for the late response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants