Skip to content

https provider not being exported for v1 functions in v4 SDK #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YannicEl opened this issue Oct 28, 2022 · 4 comments
Closed

https provider not being exported for v1 functions in v4 SDK #1286

YannicEl opened this issue Oct 28, 2022 · 4 comments

Comments

@YannicEl
Copy link
Contributor

[REQUIRED] Version info

node: v16.18.0

firebase-functions: 4.0.1

firebase-tools: 11.15.0

firebase-admin: 11.2.0

Test case

https://stackblitz.com/edit/typescript-z3azkd?file=index.ts

Steps to reproduce

Expected behavior

In the V3 SDK the https provider for V1 functions was removed meaning that imports like import { CallableContext } from 'firebase-functions/v1/https'; worked. In V4, as seen in this commit, the http provider was removed from the exports field of the root package.json. Was this a mistake or is this intended behavior? I am asking because other providers like auth or pubsub are exported just like in V3.

Actual behavior

image

@google-oss-bot
Copy link
Collaborator

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@taeold
Copy link
Contributor

taeold commented Oct 28, 2022

@YannicEl Thank you for filing AND writing up a PR. Will try to get this into our next release.

@YannicEl
Copy link
Contributor Author

Thanks a lot. Happy to help

@inlined
Copy link
Member

inlined commented Oct 31, 2022

Closing this as the fix goes out in our next release (probably today)

@inlined inlined closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants