Skip to content

Commit 9da9a4e

Browse files
authored
Unbreak v2 TS users by safely removing duplicated manifest definition (#1033)
Follows up #1032 for V2 API to fix #1031. While rebasing the branch that moved the location of manifest definition (#1003), the original file was not removed and cleaned up. Having long-lasting PR is dangeroud 🤦🏼‍♂️ .
1 parent 4b3b9b8 commit 9da9a4e

File tree

6 files changed

+4
-89
lines changed

6 files changed

+4
-89
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix issue where v2 TS users couldn't compile their code because of unexported types. (#1033)

src/cloud-functions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
durationFromSeconds,
3838
serviceAccountFromShorthand,
3939
} from './common/encoding';
40-
import { ManifestEndpoint, ManifestRequiredAPI } from './common/manifest';
40+
import { ManifestEndpoint, ManifestRequiredAPI } from './runtime/manifest';
4141

4242
/** @hidden */
4343
const WILDCARD_REGEX = new RegExp('{[^/{}]*}', 'g');

src/common/manifest.ts

Lines changed: 0 additions & 83 deletions
This file was deleted.

src/providers/https.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import {
3333
convertInvoker,
3434
copyIfPresent,
3535
} from '../common/encoding';
36-
import { ManifestEndpoint, ManifestRequiredAPI } from '../common/manifest';
36+
import { ManifestEndpoint, ManifestRequiredAPI } from '../runtime/manifest';
3737
import {
3838
CallableContext,
3939
FunctionsErrorCode,

src/runtime/manifest.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2121
// SOFTWARE.
2222
/**
23-
* @internal
2423
* An definition of a function as appears in the Manifest.
2524
*/
2625
export interface ManifestEndpoint {
@@ -68,14 +67,12 @@ export interface ManifestEndpoint {
6867
};
6968
}
7069

71-
/* @internal */
7270
export interface ManifestRequiredAPI {
7371
api: string;
7472
reason: string;
7573
}
7674

7775
/**
78-
* @internal
7976
* An definition of a function deployment as appears in the Manifest.
8077
**/
8178
export interface ManifestStack {

src/v2/providers/alerts/alerts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ManifestEndpoint } from '../../../common/manifest';
1+
import { ManifestEndpoint } from '../../../runtime/manifest';
22
import { CloudEvent, CloudFunction } from '../../core';
33
import * as options from '../../options';
44

0 commit comments

Comments
 (0)