Allow actual RegExp objects in the regex field of a textInput (#1247)

Author: Berlioz

spec/params/params.spec.ts

@@ -9,6 +9,11 @@ describe("Params spec extraction", () => {
         .default
     ).to.equal(`{{ params.BAR != 22 ? "asdf" : "jkl;" }}`);
   });
+
+  it("converts RegExps in string validation parameters to strings", () => {
+    const foo = params.defineString("FOO", { input: { text: { validationRegex: /\d{5}/ } } });
+    expect(foo.toSpec().input).to.deep.equal({ text: { validationRegex: "\\d{5}" } });
+  });
 });
 
 describe("Params value extraction", () => {

spec/runtime/manifest.spec.ts

@@ -9,6 +9,36 @@ describe("stackToWire", () => {
     params.clearParams();
   });
 
+  it("converts regular expressions used in param inputs", () => {
+    const regExpParam = params.defineString("foo", {
+      input: { text: { validationRegex: /\d{5}/ } },
+    });
+
+    const stack: ManifestStack = {
+      endpoints: {},
+      requiredAPIs: [],
+      params: [regExpParam.toSpec()],
+      specVersion: "v1alpha1",
+    };
+    const expected = {
+      endpoints: {},
+      requiredAPIs: [],
+      params: [
+        {
+          name: "foo",
+          type: "string",
+          input: {
+            text: {
+              validationRegex: "\\d{5}",
+            },
+          },
+        },
+      ],
+      specVersion: "v1alpha1",
+    };
+    expect(stackToWire(stack)).to.deep.equal(expected);
+  });
+
   it("converts stack with null values", () => {
     const stack: ManifestStack = {
       endpoints: {

src/params/types.ts

@@ -151,7 +151,7 @@ type ParamInput<T> =
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 export interface TextInput<T = unknown> {
   example?: string;
-  validationRegex?: string;
+  validationRegex?: string | RegExp;
   validationErrorMessage?: string;
 }
 
@@ -261,6 +261,10 @@ export abstract class Param<T extends string | number | boolean | string[]> exte
       out.default = paramDefault;
     }
 
+    if (out.input && "text" in out.input && out.input.text.validationRegex instanceof RegExp) {
+      out.input.text.validationRegex = out.input.text.validationRegex.source;
+    }
+
     return out;
   }
 }