Fix IngressSettings (#827)

Co-authored-by: joehan <[email protected]>

Author: takaaa220

spec/function-builder.spec.ts

@@ -200,6 +200,27 @@ describe('FunctionBuilder', () => {
     }).to.throw(Error, 'at least one region');
   });
 
+  it('should allow a ingressSettings to be set', () => {
+    const fn = functions
+      .runWith({ ingressSettings: 'ALLOW_INTERNAL_ONLY' })
+      .https.onRequest(() => {});
+
+    expect(fn.__trigger.ingressSettings).to.equal('ALLOW_INTERNAL_ONLY');
+  });
+
+  it('should throw an error if user chooses an invalid ingressSettings', () => {
+    expect(() => {
+      return functions.runWith({
+        ingressSettings: 'INVALID_OPTION',
+      } as any);
+    }).to.throw(
+      Error,
+      `The only valid ingressSettings values are: ${functions.INGRESS_SETTINGS_OPTIONS.join(
+        ','
+      )}`
+    );
+  });
+
   it('should allow a vpcConnector to be set', () => {
     const fn = functions
       .runWith({

src/cloud-functions.ts

@@ -273,6 +273,7 @@ export interface TriggerAnnotated {
     vpcConnector?: string;
     vpcConnectorEgressSettings?: string;
     serviceAccountEmail?: string;
+    ingressSettings?: string;
   };
 }
 
@@ -519,6 +520,10 @@ export function optionsToTrigger(options: DeploymentOptions) {
     trigger.maxInstances = options.maxInstances;
   }
 
+  if (options.ingressSettings) {
+    trigger.ingressSettings = options.ingressSettings;
+  }
+
   if (options.vpcConnector) {
     trigger.vpcConnector = options.vpcConnector;
   }

src/function-builder.ts

@@ -31,6 +31,7 @@ import {
   SUPPORTED_REGIONS,
   VALID_MEMORY_OPTIONS,
   VPC_EGRESS_SETTINGS_OPTIONS,
+  INGRESS_SETTINGS_OPTIONS,
 } from './function-configuration';
 import * as analytics from './providers/analytics';
 import * as auth from './providers/auth';
@@ -68,6 +69,17 @@ function assertRuntimeOptionsValid(runtimeOptions: RuntimeOptions): boolean {
     );
   }
 
+  if (
+    runtimeOptions.ingressSettings &&
+    !_.includes(INGRESS_SETTINGS_OPTIONS, runtimeOptions.ingressSettings)
+  ) {
+    throw new Error(
+      `The only valid ingressSettings values are: ${INGRESS_SETTINGS_OPTIONS.join(
+        ','
+      )}`
+    );
+  }
+
   if (
     runtimeOptions.vpcConnectorEgressSettings &&
     !_.includes(