Skip to content

Commit 1c3230e

Browse files
committed
fix: resolve all ruff linting issues
- Auto-fixed 13 issues with --unsafe-fixes: - Import reordering for better organization - Modernized isinstance() calls to use | operator - Converted .format() to f-strings - Simplified path comparisons - Converted generator to dict comprehension - Removed trailing whitespace - Updated type hints from typing module to built-in types - Manual fixes: - Added noqa comments for exception chaining (B904) where existing pattern is intentional - Implemented __hash__ method for Sentinel class to properly support equality comparison
1 parent 23df208 commit 1c3230e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+273
-245
lines changed

example/functions/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
Example Firebase Functions written in Python
33
"""
44

5-
from firebase_functions import https_fn, options, params, pubsub_fn
65
from firebase_admin import initialize_app
76

7+
from firebase_functions import https_fn, options, params, pubsub_fn
8+
89
initialize_app()
910

1011
options.set_global_options(

samples/basic_alerts/functions/main.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
"""Cloud function samples for Firebase Alerts."""
22

33
from firebase_functions import alerts_fn
4-
from firebase_functions.alerts import app_distribution_fn
5-
from firebase_functions.alerts import billing_fn
6-
from firebase_functions.alerts import crashlytics_fn
7-
from firebase_functions.alerts import performance_fn
4+
from firebase_functions.alerts import (
5+
app_distribution_fn,
6+
billing_fn,
7+
crashlytics_fn,
8+
performance_fn,
9+
)
810

911

1012
@alerts_fn.on_alert_published(alert_type=alerts_fn.AlertType.BILLING_PLAN_UPDATE)

samples/basic_db/functions/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
Example Firebase Functions for RTDB written in Python
33
"""
44

5-
from firebase_functions import db_fn, options
65
from firebase_admin import initialize_app
76

7+
from firebase_functions import db_fn, options
8+
89
initialize_app()
910

1011
options.set_global_options(region=options.SupportedRegion.EUROPE_WEST1)

samples/basic_firestore/functions/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
Example Firebase Functions for Firestore written in Python
33
"""
44

5-
from firebase_functions import firestore_fn, options
65
from firebase_admin import initialize_app
76

7+
from firebase_functions import firestore_fn, options
8+
89
initialize_app()
910

1011
options.set_global_options(region=options.SupportedRegion.EUROPE_WEST1)

samples/basic_params/functions/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22
Example Function params & inputs.
33
"""
44

5-
from firebase_functions import storage_fn, params
65
from firebase_admin import initialize_app
76

7+
from firebase_functions import params, storage_fn
8+
89
initialize_app()
910

1011
bucket = params.StringParam(

samples/basic_storage/functions/main.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22
Example Firebase Functions for Storage triggers.
33
"""
44

5-
from firebase_functions import storage_fn
6-
from firebase_functions.storage_fn import StorageObjectData, CloudEvent
75
from firebase_admin import initialize_app
86

7+
from firebase_functions import storage_fn
8+
from firebase_functions.storage_fn import CloudEvent, StorageObjectData
9+
910
initialize_app()
1011

1112

samples/basic_tasks/functions/main.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55

66
from firebase_admin import initialize_app
77
from google.cloud import tasks_v2
8-
from firebase_functions import tasks_fn, https_fn
9-
from firebase_functions.options import SupportedRegion, RetryConfig, RateLimits
8+
9+
from firebase_functions import https_fn, tasks_fn
10+
from firebase_functions.options import RateLimits, RetryConfig, SupportedRegion
1011

1112
app = initialize_app()
1213

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"""
1717

1818
from os import path
19+
1920
from setuptools import find_packages, setup
2021

2122
install_requires = [

src/firebase_functions/alerts/app_distribution_fn.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919
import dataclasses as _dataclasses
2020
import functools as _functools
2121
import typing as _typing
22+
2223
import cloudevents.http as _ce
23-
from firebase_functions.alerts import FirebaseAlertData
2424

2525
import firebase_functions.private.util as _util
26-
27-
from firebase_functions.core import T, CloudEvent
26+
from firebase_functions.alerts import FirebaseAlertData
27+
from firebase_functions.core import CloudEvent, T
2828
from firebase_functions.options import AppDistributionOptions
2929

3030

@@ -65,7 +65,7 @@ class InAppFeedbackPayload:
6565

6666
feedback_report: str
6767
"""
68-
Resource name. Format:
68+
Resource name. Format:
6969
`projects/{project_number}/apps/{app_id}/releases/{release_id}/feedbackReports/{feedback_id}`
7070
"""
7171

src/firebase_functions/alerts/billing_fn.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919
import dataclasses as _dataclasses
2020
import functools as _functools
2121
import typing as _typing
22+
2223
import cloudevents.http as _ce
23-
from firebase_functions.alerts import FirebaseAlertData
2424

2525
import firebase_functions.private.util as _util
26-
27-
from firebase_functions.core import T, CloudEvent
26+
from firebase_functions.alerts import FirebaseAlertData
27+
from firebase_functions.core import CloudEvent, T
2828
from firebase_functions.options import BillingOptions
2929

3030

0 commit comments

Comments
 (0)