From 6e7d4e268171e6a299173ede36d26ba1c869ba94 Mon Sep 17 00:00:00 2001 From: Vimanyu Date: Thu, 8 Apr 2021 10:08:43 -0700 Subject: [PATCH 1/3] Removing google play requirement. --- auth/src/auth.cc | 3 --- database/src/common/database.cc | 2 -- functions/src/common/functions.cc | 2 -- storage/src/common/storage.cc | 2 -- 4 files changed, 9 deletions(-) diff --git a/auth/src/auth.cc b/auth/src/auth.cc index 52abd08ff3..9726172523 100644 --- a/auth/src/auth.cc +++ b/auth/src/auth.cc @@ -46,7 +46,6 @@ FIREBASE_APP_REGISTER_CALLBACKS( auth, { - FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app); return ::firebase::kInitResultSuccess; }, { @@ -75,8 +74,6 @@ Auth* Auth::GetAuth(App* app, InitResult* init_result_out) { return existing_auth; } - FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out); - // Create the platform dependent version of Auth. void* auth_impl = CreatePlatformAuth(app); if (!auth_impl) return nullptr; diff --git a/database/src/common/database.cc b/database/src/common/database.cc index 58a963d814..d0c5095a41 100644 --- a/database/src/common/database.cc +++ b/database/src/common/database.cc @@ -43,7 +43,6 @@ FIREBASE_APP_REGISTER_CALLBACKS( database, { - FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app); return ::firebase::kInitResultSuccess; }, { @@ -84,7 +83,6 @@ Database* Database::GetInstance(App* app, const char* url, if (init_result_out != nullptr) *init_result_out = kInitResultSuccess; return it->second; } - FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out); Database* database = url ? new Database(app, new DatabaseInternal(app, url)) : new Database(app, new DatabaseInternal(app)); diff --git a/functions/src/common/functions.cc b/functions/src/common/functions.cc index 3821523850..3dcf44e946 100644 --- a/functions/src/common/functions.cc +++ b/functions/src/common/functions.cc @@ -40,7 +40,6 @@ FIREBASE_APP_REGISTER_CALLBACKS( functions, { - FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app); return ::firebase::kInitResultSuccess; }, { @@ -84,7 +83,6 @@ Functions* Functions::GetInstance(::firebase::App* app, const char* region, if (init_result_out != nullptr) *init_result_out = kInitResultSuccess; return it->second; } - FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out); Functions* functions = new Functions(app, region_idx.c_str()); if (!functions->internal_->initialized()) { diff --git a/storage/src/common/storage.cc b/storage/src/common/storage.cc index afe4564e77..65bc605571 100644 --- a/storage/src/common/storage.cc +++ b/storage/src/common/storage.cc @@ -41,7 +41,6 @@ FIREBASE_APP_REGISTER_CALLBACKS( storage, { - FIREBASE_UTIL_RETURN_FAILURE_IF_GOOGLE_PLAY_UNAVAILABLE(*app); return ::firebase::kInitResultSuccess; }, { @@ -103,7 +102,6 @@ Storage* Storage::GetInstance(::firebase::App* app, const char* url, if (init_result_out != nullptr) *init_result_out = kInitResultSuccess; return it->second; } - FIREBASE_UTIL_RETURN_NULL_IF_GOOGLE_PLAY_UNAVAILABLE(*app, init_result_out); Storage* storage = new Storage(app, url); if (!storage->internal_->initialized()) { From fbe072cb2003360ff3c75e42a8ba654047e87760 Mon Sep 17 00:00:00 2001 From: Vimanyu Date: Mon, 12 Apr 2021 11:19:17 -0700 Subject: [PATCH 2/3] removing checks for google play services --- release_build_files/readme.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index ec4f1ab034..fc5b8c5c9b 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -584,6 +584,8 @@ code. - General: Fixed rare crashes at application exit when destructors were being executed ([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)). + - General: Removed checks for Google Play Services in C++ for Auth, Database, + Functions and Storage as the native Android packages no longer need it. ### 7.1.1 - Changes From dc2dbfb2133151d50dd91ffff3f217282b8bbfb8 Mon Sep 17 00:00:00 2001 From: Vimanyu Date: Mon, 12 Apr 2021 12:16:57 -0700 Subject: [PATCH 3/3] fixed release notes --- release_build_files/readme.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release_build_files/readme.md b/release_build_files/readme.md index fc5b8c5c9b..35f4e10dd1 100644 --- a/release_build_files/readme.md +++ b/release_build_files/readme.md @@ -584,8 +584,9 @@ code. - General: Fixed rare crashes at application exit when destructors were being executed ([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)). - - General: Removed checks for Google Play Services in C++ for Auth, Database, + - General (Android): Removed checks for Google Play services for Auth, Database, Functions and Storage as the native Android packages no longer need it. + ([#361](https://github.com/firebase/firebase-cpp-sdk/pull/361)). ### 7.1.1 - Changes