Skip to content

Commit ce2a22d

Browse files
authored
Properly convert milliseconds to seconds (#767)
* Properly convert milliseconds to seconds Currently, a value expressed in milliseconds is directly assigned to a variable which is supposed to store seconds and it's later converted to mills again. Thus, convert properly upon assignment * Update readme.md
1 parent a8b5b12 commit ce2a22d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

release_build_files/readme.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,9 @@ code.
584584
([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745))
585585
- Messaging (Android): Fixed crash during initialization.
586586
([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760))
587-
587+
- Remote Config (Desktop): Fixed cache expiration time value used by
588+
`RemoteConfig::FetchAndActivate()`.
589+
([#767](https://github.com/firebase/firebase-cpp-sdk/pull/767))
588590

589591
### 8.7.0
590592
- Changes

remote_config/src/desktop/remote_config_desktop.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ Future<bool> RemoteConfigInternal::FetchAndActivate() {
140140
future_impl_.SafeAlloc<bool>(kRemoteConfigFnFetchAndActivate);
141141

142142
cache_expiration_in_seconds_ =
143-
config_settings_.minimum_fetch_interval_in_milliseconds;
143+
config_settings_.minimum_fetch_interval_in_milliseconds /
144+
::firebase::internal::kMillisecondsPerSecond;
144145

145146
uint64_t milliseconds_since_epoch =
146147
std::chrono::duration_cast<std::chrono::milliseconds>(

0 commit comments

Comments
 (0)