Skip to content

Commit 9821ba9

Browse files
committed
Fix openssl build for x86_64 Mac build.
1 parent 48d1035 commit 9821ba9

File tree

1 file changed

+9
-18
lines changed

1 file changed

+9
-18
lines changed

.github/workflows/integration_tests.yml

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ env:
5252
xcodeVersion: '16.2'
5353
artifactRetentionDays: 2
5454
GITHUB_TOKEN: ${{ github.token }}
55-
# All self-hosted ARM Mac runners should have this label. Due to how
56-
# our custom reporting works, it must be exactly two words separated
57-
# by a hyphen. The first word must be "macos". The second word will
58-
# be omitted from the summary log.
59-
runnerLabelMacArm64: "macos-m1custom"
6055

6156
jobs:
6257
check_and_prepare:
@@ -77,8 +72,6 @@ jobs:
7772
xcode_version: ${{ steps.matrix_config.outputs.xcode_version }}
7873
ios_device: ${{ steps.matrix_config.outputs.ios_device }}
7974
tvos_device: ${{ steps.matrix_config.outputs.tvos_device }}
80-
# Copy the runner label here because matrix specifiers cannot see env.
81-
runner_label_macos_arm64: ${{ env.runnerLabelMacArm64 }}
8275
steps:
8376
### Fail the workflow if the user does not have admin access to run the tests.
8477
- name: Check if user has permission to trigger tests
@@ -276,15 +269,15 @@ jobs:
276269
- os: macos-14
277270
arch: x86
278271
# Until we support building openssl from source, we can't use the
279-
# system's openssl when cross-compiling, except on Linux. Builds all
280-
# happen on x64 machines, so arm64 and x86 are technically
281-
# cross-compiling.
272+
# system's openssl when cross-compiling, except on Linux. Builds on Linux
273+
# happen on x64 machines, so x86 is technically cross-compiling. Builds on
274+
# Mac happen on arm64 machines, so x64 is technically cross-compiling.
282275
- os: windows-latest
283276
ssl_variant: openssl
284277
arch: x86
285278
- os: macos-14
286279
ssl_variant: openssl
287-
arch: arm64
280+
arch: x64
288281
steps:
289282
- uses: lukka/get-cmake@latest
290283
with:
@@ -775,17 +768,15 @@ jobs:
775768
- os: macos-14
776769
arch: x86
777770
# Until we support building openssl from source, we can't use the
778-
# system's openssl when cross-compiling, except on Linux. Builds all
779-
# happen on x64 machines, so arm64 and x86 are technically
780-
# cross-compiling.
771+
# system's openssl when cross-compiling, except on Linux. Builds on Linux
772+
# happen on x64 machines, so x86 is technically cross-compiling. Builds on
773+
# Mac happen on arm64 machines, so x64 is technically cross-compiling.
781774
- os: windows-latest
782775
ssl_variant: openssl
783776
arch: x86
784-
# Custom for this matrix: MacOS GitHub-hosted runner cannot test arm64
785-
# code. Exclude that scenario from running here; it will run in
786-
# test_desktop_custom_runners.
787777
- os: macos-14
788-
arch: arm64
778+
ssl_variant: openssl
779+
arch: x64
789780
steps:
790781
- uses: actions/checkout@v3
791782
with:

0 commit comments

Comments
 (0)