From 727c46ff339debcf76fe978878e4746c9d648c34 Mon Sep 17 00:00:00 2001 From: Peter Mikitsh Date: Tue, 25 Sep 2018 17:29:54 -0700 Subject: [PATCH 1/5] [FieldArray] extend React.Component --- src/FieldArray.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FieldArray.js b/src/FieldArray.js index 153b52b..4e0bfd4 100644 --- a/src/FieldArray.js +++ b/src/FieldArray.js @@ -31,7 +31,7 @@ type State = { state: ?FieldState } -class FieldArray extends React.PureComponent { +class FieldArray extends React.Component { context: ReactContext props: Props state: State From 9c3055dc6da23132c212eb2bbb3ba0d8d7bac2ff Mon Sep 17 00:00:00 2001 From: Peter Mikitsh Date: Tue, 25 Sep 2018 17:36:36 -0700 Subject: [PATCH 2/5] [FieldArray.test.js] fix unit test --- src/FieldArray.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FieldArray.test.js b/src/FieldArray.test.js index 1c10ba5..7e590bd 100644 --- a/src/FieldArray.test.js +++ b/src/FieldArray.test.js @@ -135,7 +135,7 @@ describe('FieldArray', () => { const button = TestUtils.findRenderedDOMComponentWithTag(dom, 'button') TestUtils.Simulate.click(button) - expect(renderArray).toHaveBeenCalledTimes(2) + expect(renderArray).toHaveBeenCalledTimes(3) expect(renderArray.mock.calls[1][0].value).toBeUndefined() }) From 0556643cd3fd68dba979a15ed5dd750365b46986 Mon Sep 17 00:00:00 2001 From: Peter Mikitsh Date: Tue, 25 Sep 2018 17:41:53 -0700 Subject: [PATCH 3/5] [FieldArray.test.js] fix unit test --- src/FieldArray.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/FieldArray.test.js b/src/FieldArray.test.js index 7e590bd..8ef1665 100644 --- a/src/FieldArray.test.js +++ b/src/FieldArray.test.js @@ -135,7 +135,7 @@ describe('FieldArray', () => { const button = TestUtils.findRenderedDOMComponentWithTag(dom, 'button') TestUtils.Simulate.click(button) - expect(renderArray).toHaveBeenCalledTimes(3) + expect(renderArray).toHaveBeenCalledTimes(2) expect(renderArray.mock.calls[1][0].value).toBeUndefined() }) @@ -246,7 +246,7 @@ describe('FieldArray', () => { renderArray.mock.calls[0][0].fields.push('c') await sleep(2) - expect(renderArray).toHaveBeenCalledTimes(2) + expect(renderArray).toHaveBeenCalledTimes(3) expect(renderArray.mock.calls[1][0].meta.valid).toBe(false) expect(renderArray.mock.calls[1][0].meta.error).toBe('Too long') }) From 8e1289fa6792da1cc48f38b05ea2331836ad0027 Mon Sep 17 00:00:00 2001 From: Peter Mikitsh Date: Tue, 25 Sep 2018 19:38:35 -0700 Subject: [PATCH 4/5] [FieldArray] fix unit test --- src/FieldArray.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/FieldArray.test.js b/src/FieldArray.test.js index 8ef1665..4614ec4 100644 --- a/src/FieldArray.test.js +++ b/src/FieldArray.test.js @@ -247,8 +247,8 @@ describe('FieldArray', () => { await sleep(2) expect(renderArray).toHaveBeenCalledTimes(3) - expect(renderArray.mock.calls[1][0].meta.valid).toBe(false) - expect(renderArray.mock.calls[1][0].meta.error).toBe('Too long') + expect(renderArray.mock.calls[2][0].meta.valid).toBe(false) + expect(renderArray.mock.calls[2][0].meta.error).toBe('Too long') }) it('should provide forEach', () => { From 9de94513bd1bf98e83681a06a2b19df42b6a1f62 Mon Sep 17 00:00:00 2001 From: Peter Mikitsh Date: Tue, 25 Sep 2018 19:38:35 -0700 Subject: [PATCH 5/5] [FieldArray] fix unit test --- src/FieldArray.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/FieldArray.test.js b/src/FieldArray.test.js index 8ef1665..4614ec4 100644 --- a/src/FieldArray.test.js +++ b/src/FieldArray.test.js @@ -247,8 +247,8 @@ describe('FieldArray', () => { await sleep(2) expect(renderArray).toHaveBeenCalledTimes(3) - expect(renderArray.mock.calls[1][0].meta.valid).toBe(false) - expect(renderArray.mock.calls[1][0].meta.error).toBe('Too long') + expect(renderArray.mock.calls[2][0].meta.valid).toBe(false) + expect(renderArray.mock.calls[2][0].meta.error).toBe('Too long') }) it('should provide forEach', () => {