fix(remove): submit errors are not removed on "fields.remove" call

Author: Vitaliy Parkhomenko

src/remove.js

@@ -27,19 +27,12 @@ const remove: Mutator<any> = (
       if (fieldIndex === index) {
         // delete any subfields for this array item
         delete state.fields[key]
-
         // delete any submitErrors for this array item
-        // if root key of array item and has submitErrors
+        // if the root key of the delete index
         if (key === `${name}[${index}]`) {
-          // do it only for removable index
-          // Can array be in root?
-          // formState.submitErrors[]
-          // formState.submitErrors.pathToArray[]
-          const path = name
-            ? `formState.submitErrors.${name}`
-            : `formState.submitErrors${name}`
+          const path = `formState.submitErrors.${name}`
           const submitErrors = getIn(state, path)
-          // if has submitErrors
+          // if has submitErrors for array
           if (Array.isArray(submitErrors)) {
             submitErrors.splice(index, 1)
             state = setIn(state, path, submitErrors)

src/remove.test.js

@@ -498,145 +498,4 @@ describe('remove', () => {
       foo: [{ key: 'B Submit Error' }]
     })
   })
-
-  it('should remove value from the specified index with submitError if one error in array (root is an array)', () => {
-    const array = ['a', { key: 'val' }]
-    const changeValue = jest.fn()
-    const renameField = jest.fn()
-    function blur0() {}
-    function change0() {}
-    function focus0() {}
-    function blur1() {}
-    function change1() {}
-    function focus1() {}
-    function blur2() {}
-    function change2() {}
-    function focus2() {}
-    const state = {
-      formState: {
-        values: array,
-        submitErrors: [
-          {
-            key: 'A Submit Error'
-          }
-        ]
-      },
-      fields: {
-        '[0]': {
-          name: '[0]',
-          blur: blur0,
-          change: change0,
-          focus: focus0,
-          touched: true,
-          error: 'A Error'
-        },
-        '[0].key': {
-          name: '[0].key',
-          blur: blur2,
-          change: change2,
-          focus: focus2,
-          touched: false,
-          error: 'A Error'
-        },
-        '[1]': {
-          name: '[1]',
-          blur: blur1,
-          change: change1,
-          focus: focus1,
-          touched: false,
-          error: 'B Error'
-        },
-        '[1].key': {
-          name: '[1].key',
-          blur: blur2,
-          change: change2,
-          focus: focus2,
-          touched: false,
-          error: 'B Error'
-        }
-      }
-    }
-
-    const returnValue = remove(['', 0], state, {
-      renameField,
-      changeValue,
-      getIn,
-      setIn
-    })
-    expect(returnValue).toBeUndefined()
-    expect(getIn(state, 'formState.submitErrors')).toEqual([])
-  })
-
-  it('should remove value from the specified index with submitError if two errors in array (root is an array)', () => {
-    const array = ['a', { key: 'val' }]
-    const changeValue = jest.fn()
-    const renameField = jest.fn()
-    function blur0() {}
-    function change0() {}
-    function focus0() {}
-    function blur1() {}
-    function change1() {}
-    function focus1() {}
-    function blur2() {}
-    function change2() {}
-    function focus2() {}
-    const state = {
-      formState: {
-        values: array,
-        submitErrors: [
-          {
-            key: 'A Submit Error'
-          },
-          {
-            key: 'B Submit Error'
-          }
-        ]
-      },
-      fields: {
-        '[0]': {
-          name: '[0]',
-          blur: blur0,
-          change: change0,
-          focus: focus0,
-          touched: true,
-          error: 'A Error'
-        },
-        '[0].key': {
-          name: '[0].key',
-          blur: blur2,
-          change: change2,
-          focus: focus2,
-          touched: false,
-          error: 'A Error'
-        },
-        '[1]': {
-          name: '[1]',
-          blur: blur1,
-          change: change1,
-          focus: focus1,
-          touched: false,
-          error: 'B Error'
-        },
-        '[1].key': {
-          name: '[1].key',
-          blur: blur2,
-          change: change2,
-          focus: focus2,
-          touched: false,
-          error: 'B Error'
-        }
-      }
-    }
-
-    const returnValue = remove(['', 0], state, {
-      renameField,
-      changeValue,
-      getIn,
-      setIn
-    })
-    expect(returnValue).toBeUndefined()
-    expect(getIn(state, 'formState.submitErrors')).toEqual([
-      { key: 'B Submit Error' }
-    ])
-  })
 })