Code Quality: Refactored ToolbarViewModel #13659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
reviewed
Nov 9, 2023
…iles into Improve-ParthBreadcrumb
yaira2
reviewed
Nov 13, 2023
Member
Author
|
Can you merge? |
Member
Author
|
Yes |
yaira2
reviewed
Nov 16, 2023
yaira2
reviewed
Nov 16, 2023
|
|
||
| <!-- Header --> | ||
| <TextBlock | ||
| Margin="0,0,4,0" |
yaira2
approved these changes
Nov 16, 2023
yaira2
added
ready to merge
gave92
added a commit
to gave92/files-uwp
that referenced
this pull request
Nov 18, 2023
)" This reverts commit 60f714f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored ToolbarViewModel and separated it into ToolbarViewModel and PathBreadcrumbViewModel.
Task Checklist
Known Issues
N/A
PR Checklist
Steps To Validate Changes
>and using the keyboard shortcut.Screenshots
N/A
Footnotes
If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩
If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead. ↩