Rewrite timer logic #3
Open
+266
−247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Jul 14, 2024
| // WARNING: Tickers will cause this function to continue forever until something cancels the ticker. | ||
| // It will sleep after each bit of progress to the tickers a chance to run, but using this with | ||
| // tickers is not recommended. | ||
| func (m *Mock) WaitForAllTimers() time.Time { |
Member
Author
There was a problem hiding this comment.
I can add a RunNextTimer later, that should be fairly trivial.
There was a problem hiding this comment.
RunNextTimer or a way to cancel WaitForAllTimers would be nice.
Stebalien
commented
Jul 14, 2024
| t.stopped = true | ||
| t.mock.removeClockTimer((*internalTimer)(t)) | ||
| // Ticker is a mock implementation of [time.Ticker]. | ||
| type Ticker struct { |
Member
Author
There was a problem hiding this comment.
Restructured to be smaller (when not using mocktime) and to avoid having to abstract over Ticker versus Timer in the mock logic.
1. Don't advance time all at once, advance to each deadline. 2. Use a heap instead of constantly sorting/iterating. 3. Modernize the context logic to avoid extra goroutines. 4. Make calling Set/Add/etc. thread-safe. All callers will cooperatively advance the clock until the requested time.
Also improve reliability of immediately firing timers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really necessary for small-scale tests, but... I wanted to clean some things up a bit.