feat: piece deletion and cleanup #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Oct 31, 2025
Kubuxu
reviewed
Oct 31, 2025
Kubuxu
reviewed
Nov 4, 2025
Kubuxu
reviewed
Nov 4, 2025
Kubuxu
reviewed
Nov 4, 2025
Kubuxu
reviewed
Nov 4, 2025
Kubuxu
approved these changes
Nov 4, 2025
Collaborator
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
SGTM, IDK if you want to merge right now, of for me to first review the terminate PR with smaller diff
Contributor
Author
Please review the other one with smaller diff. We can merge in one later. |
LexLuthr
force-pushed
the
feat/piece-deletion
branch
from
d7c8382 to
e7a7daa
Compare
LexLuthr
force-pushed
the
feat/piece-deletion
branch
from
e7a7daa to
9f884e5
Compare
LexLuthr
added a commit
that referenced
this pull request
Nov 7, 2025
* settle lockup and dataSet delete * minor fixes * fix imports * fix payee * apply suggestions from review * apply review suggestions * fix SQL * remove unused param * update settle task frequency * feat: piece deletion and cleanup (#771) * piece deletion and cleanup * use join * fix IPNI cleanup * add piece_cid index to pdp_piecerefs table * fix args * more conditional checks * move delete lower * fix deletion logic * delete conditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.