feat: allow player to swim #290
Open
+147
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tonguechaude
force-pushed
the
feat-swimming
branch
from
4df2350 to
367cde5
Compare
radstevee
approved these changes
Dec 7, 2025
GStudiosX2
reviewed
Dec 7, 2025
ReCore-sys
reviewed
Dec 7, 2025
Collaborator
ReCore-sys
left a comment
ReCore-sys
left a comment
There was a problem hiding this comment.
Mostly fine, just some OOP nitpicks
|
|
||
| /// Check if a player is in water by testing at eye level | ||
| fn is_player_in_water(state: &ferrumc_state::GlobalState, pos: &Position) -> bool { | ||
| let eye_pos = IVec3::new( |
Collaborator
There was a problem hiding this comment.
Might be cleaner to put it all in a regular Vec3, then floor that and convert to IVec3
Tonguechaude
force-pushed
the
feat-swimming
branch
from
b548eaf to
7faab41
Compare
Tonguechaude
force-pushed
the
feat-swimming
branch
from
d56801d to
321c9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just allow player to swim ! 💦 (didn't find pool emoji sry)