Skip to content

hls suggests quick fixes but cannot apply them #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EmixamPP opened this issue Apr 30, 2023 · 3 comments
Closed

hls suggests quick fixes but cannot apply them #1

EmixamPP opened this issue Apr 30, 2023 · 3 comments

Comments

@EmixamPP
Copy link

Hello,

First, thank you for providing hls has a rpm package.

Personally, I use the vscode extension to exploit the hls. However, the hls can suggest quick fixes, but it cannot apply them.

An issue haskell/haskell-language-server#3241 has been created for this problem last October, but was fixed by the pr haskell/haskell-language-server#3469 in February.

Although this package has the same version as the one provided by GHCup, I don't encounter this limitation when I use the latter to install hls.

I'm just pointing out this problem, if you don't have time to look at it, there is of course no worries.

@juhp
Copy link
Member

juhp commented May 2, 2023

Okay thanks for reporting and sharing.
Currently the hlint plugin is disabled in the Fedora packages, except for haskell-language-server-ghc9.4.

@EmixamPP
Copy link
Author

EmixamPP commented May 4, 2023

Thank you for your reply.

Unfortunately, I cannot use haskell-language-server-ghc9.4. Because of the conflict with the ghc libraries that are built in the repo for ghc 9.2.6.

So if I understand correctly, this will be fixed in a future Fedora release that will upgrade ghc to a version >= 9.4?

Anyway, it's not a big deal. Feel free to close the issue if it's pointless to leave it open.

@juhp
Copy link
Member

juhp commented May 6, 2023

No, we already have ghc9.4 package in Fedora.
It's just that upstream is relaxed with its releases and dependencies.
I think it may need allow-newer to build the hlint module for older ghc perhaps.

@juhp juhp closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants