[RFC] Request for testing of JSON config

[CarterLi]

There are no documentations yet ( JSON schema is planned ). Keys can mostly map to the traditional command flags. Here is an example ( when config.jsonc is found, config.conf will be ignored )

My config file

// ~/.config/fastfetch/config.json
{
  "logo": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L900
    "type": "iterm",
    "source": "/home/carter/linux.png", // https://en.wikipedia.org/wiki/Linux#/media/File:Tux.svg
    "width": 30,
    "height": 14,
    "padding": {
      "top": 2,
      "left": 1,
      "right": 2
    }
  },
  "general": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L872
    "allowSlowOperations": true,
    "stat": true
  },
  "display": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L906
    "color": {
      "keys": "yellow"
    },
    "percentType": 9,
    "hideCursor": false
  },
  "modules": [
    "title",
    "separator",
    "os",
    "host",
    "kernel",
    "uptime",
    "processes",
    "packages",
    "shell",
    {
      "type": "display",
      "detectName": true
    },
    "brightness",
    "de",
    "wm",
    "wmtheme",
    "theme",
    "icons",
    "cursor",
    "terminal",
    "terminalfont",
    {
      "type": "cpu",
      "temp": true
    },
    {
      "type": "gpu",
      "forceVulkan": true
    },
    "memory",
    "swap",
    "disk",
    "media",
    "battery",
    {
      "type": "localip",
      "showIpv6": true
    },
    "cpuusage",
    "wifi",
    "locale",
    "vulkan",
    "opengl",
    "bluetooth",
    "sound",
    "datetime",
    "break",
    "colors"
  ]
}

The result

[tdtooke]

Thanks. I'll definitely give this a go when I get home.

Edit: What you have works fine on my end. Will certain things still work again in the future? I have noticed none of the old themes I made work anymore. They fail for several reasons. Mostly anything I ever used starting with --set-keyless no longer works. I get the gist of what you're doing here. Would really like a guide on how to do other keys like host key, cpu key, etc.

[CarterLi]

Mostly anything I ever used starting with --set-keyless no longer works.

Breaking change is the main reason we bump the major version of fastfetch. --set-key and --set-keyless were implemented as a hack, and will be replaced by the new Custom module.

Would really like a guide on how to do other keys like host key, cpu key, etc.

Definitely yes. I just need more time. However, --host-key and --cpu-key should work like what they did.

[tdtooke]

I'm wanting to go full json so my question is for those keys would I want that to be within "display"? Adding just under "color" something like "host-key" : "myhostkey"?

Edit: I'm still at work so I won't be able to experiment 'til maybe tomorrow, just so you know.
Ok, home now and making progress jsonifying my theme. I see where you set the color for all keys under display, was wondering if I can set custom colors for individual keys. I do love the logo you use but I kinda want to go back to my 2 colored ascii logo. I played around in the logo settings but couldn't figure out what the equivalent of --logo-color-1 and --logo-color-2 is. Also now some of my keys have an unwanted added colon. That's really not a big deal but it makes the appearance inconsistent. I"ll include my json and a screenshot.

// ~/.config/fastfetch/config.json
{
  "logo": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L900
    "type": "iterm",
    "source": "/home/travis/mysources/Tux.png", // https://en.wikipedia.org/wiki/Linux#/media/File:Tux.svg
    "width": 30,
    "height": 14,
    "padding": {
      "top": 2,
      "left": 1,
      "right": 2
    }
  },
  "general": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L872
    "allowSlowOperations": true
  },
  "display": { // https://github.com/fastfetch-cli/fastfetch/blob/71beb626c30c5755613d743d9349f7a95effbe6c/src/fastfetch.c#L906
    "color": {
      "keys": "yellow"
    },
    "percentType": 9,
    "hideCursor": false,
    "separator": "  "
  },
  "modules": [
    "title",
    "separator",
    {
    "type": "host",
    "key": " PC"
    },
    {
    "type": "board",
    "key": "  ├"
    },
    {
    "type": "CPU",
    "key": "  ├"
    },
    {
    "type": "gpu",
    "forceVulkan": true,
    "key": "  ├﬙"
    },
    {
    "type": "display",
    "key": "  ├"
    },
    {
    "type": "memory",
    "key": "  ╰"
    },
    "break",
    {
    "type": "os",
    "key": " OS"
    },
    {
    "type": "kernel",
    "key": "  ├"
    },
    {
    "type": "shell",
    "key": "  ├"
    },
    {
    "type": "terminal",
    "key": "  ├"
    },
    {
    "type": "TerminalFont",
    "key": "  ├"
    },
    {
    "type": "Locale",
    "key": "  ├"
    },
    {
    "type": "Packages",
    "key": "  ╰"
    },
    "break",
    {
    "type": "DE",
    "key": " DE"
    },
    {
    "type": "WM",
    "key": "  ├"
    },
    {
    "type": "WMTheme",
    "key": "  ├"
    },
    {
    "type": "Theme",
    "key": "  ├"
    },
    {
    "type": "Icons",
    "key": "  ├"
    },
    {
    "type": "Font",
    "key": "  ├"
    },
    {
    "type": "Cursor",
    "key": "  ╰󰇀"
    },
    "break",
    "colors"
  ]
}

https://i.postimg.cc/N0Cxt5Rx/fetch.png

[CarterLi]

I see where you set the color for all keys under display, was wondering if I can set custom colors for individual keys.

You can do it with

{
    "type": "host",
    "key": "\\e[34mhost" // note double `\`s are required
}

for now, but we may support it some day. Let me focus porting existing features.

but couldn't figure out what the equivalent of --logo-color-1 and --logo-color-2 is.

{
    "logo": {
        "color": {
            "1": "white",
            "2": "cyan",
            // and whatever
        }
    }
}

You may add

"$schema": "https://raw.githubusercontent.com/fastfetch-cli/fastfetch/dev/src/data/json_schema.jsonc"

at the beginning of the JSON config file and use vscode to get some suggestions when typing

Also now some of my keys have an unwanted added colon.

Fixed in 184a6de

[CarterLi]

Mostly anything I ever used starting with --set-keyless no longer works.

{
    "type": "custom",
    "format": "whatever you want"
}

[tdtooke]

Thanks you!!! I actually did try that way to color a key just without the extra '\" I tried a variation of what you did for logo colors. I really should have known but for some reason my brain was telling me there wouldn't be something named simply "1". I'm beginning to suspect the colon I see after the key is hard coded in so I won't ask for that.

Edit: You fixed the colon thing, thanks!!! Now we have achieved perfection on my theme!

[tdtooke]

Just in case it would help anybody else wanting to go in the direction I tend to go theming wise I'll post my json. Thanks to CarterLi for fixing my other post. I guess the old bbcode tags I'm used to using don't always work.

{
  "$schema": "https://raw.githubusercontent.com/fastfetch-cli/fastfetch/dev/src/data/json_schema.jsonc",
  "logo": {
    "padding": {
      "top": 3,
      "left": 1
    },
    "color": {
      "1": "36",
      "2": "32"
    }
  },
  "general": {
    "allowSlowOperations": true
  },
  "display": {
    "color": {
      "title": "33"
    },
    "percentType": 9,
    "hideCursor": false,
    "separator": "   "
  },
  "modules": [
    "title",
    "separator",
    {
    "type": "host",
    "key": "\\e[36m PC"
    },
    {
    "type": "board",
    "key": "\\e[36m  ├"
    },
    {
    "type": "CPU",
    "key": "\\e[36m  ├"
    },
    {
    "type": "gpu",
    "key": "\\e[36m  ├﬙"
    },
    {
    "type": "display",
    "key": "\\e[36m  ├"
    },
    {
    "type": "memory",
    "key": "\\e[36m  ╰"
    },
    "break",
    {
    "type": "os",
    "key": "\\e[32m OS"
    },
    {
    "type": "kernel",
    "key": "\\e[32m  ├"
    },
    {
    "type": "shell",
    "key": "\\e[32m  ├"
    },
    {
    "type": "terminal",
    "key": "\\e[32m  ├"
    },
    {
    "type": "TerminalFont",
    "key": "\\e[32m  ├"
    },
    {
    "type": "Locale",
    "key": "\\e[32m  ├"
    },
    {
    "type": "Packages",
    "key": "\\e[32m  ╰"
    },
    "break",
    {
    "type": "DE",
    "key": "\\e[33m DE"
    },
    {
    "type": "WM",
    "key": "\\e[33m  ├"
    },
    {
    "type": "WMTheme",
    "key": "\\e[33m  ├"
    },
    {
    "type": "Theme",
    "key": "\\e[33m  ├"
    },
    {
    "type": "Icons",
    "key": "\\e[33m  ├"
    },
    {
    "type": "Font",
    "key": "\\e[33m  ├"
    },
    {
    "type": "Cursor",
    "key": "\\e[33m  ╰󰇀"
    },
    "break",
    {
    "type": "custom",
    "format": "   \\e[38m \\e[37m \\e[36m \\e[35m \\e[34m \\e[33m \\e[32m \\e[31m"
    }
  ]
}

And if you want to know what that will produce on konsole with the Mega-Konsole theme then:

https://i.postimg.cc/VkhB8zxb/fetch.png

[CarterLi]

Added keyColor and --<module>-key-color

Usage:

{
    "type": "Cursor",
    "keyColor": "cyan"
}

[tdtooke]

I would suggest you move your config into presets. A lot of people will like that one. I just might convert a lot of the old examples into the new format and make a pull request. Also will there be a way to have a config file where you can choose your json theme?

[CarterLi]

What is a json theme?

[tdtooke]

The contents of config.jsonc are what I would call a theme. As is if I want to change appearance I need to rename a config I created as config.jsonc. I was thinking of themes being stored in the presets directory and in a config file you might have something like "theme" : "mytheme"