Fix Flow type that event target can be null #13124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass null sometimes when the event target has disappeared. E.g. when touches fires on a deleted node.
nhunzaker
reviewed
Jun 29, 2018
|
|
||
| export function dispatchEvent( | ||
| target: Object, | ||
| target: null | Object, |
Contributor
There was a problem hiding this comment.
In what cases is target not a Fiber? Like could this type be null | Fiber?
Collaborator
Author
There was a problem hiding this comment.
It's never not a Fiber, hence the case below, but the caller cannot guarantee it right now.
Collaborator
Author
There was a problem hiding this comment.
Ultimately it is because the "internalInstanceHandle" is supposed to be an opaque object as far as the host configs are concerned. So it should really be using opaque types instead.
nhunzaker
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass null sometimes when the event target has disappeared. E.g. when touches fires on a deleted node.