Remove unnecessary clearContainer call

sebmarkbage · sebmarkbage · commit b77b4de3ba05 · 2021-12-16T19:36:11.000-05:00
This was added when we added error recovery for hydration errors. However,
when the fix up pass happens later on, it'll still call clearContainer in
the commit phase. So this call is unnecessary.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -86,7 +86,6 @@ import {
   cancelTimeout,
   noTimeout,
   afterActiveInstanceBlur,
-  clearContainer,
   getCurrentEventPriority,
   supportsMicrotasks,
   errorHydratingContainer,
@@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) {
     if (__DEV__) {
       errorHydratingContainer(root.containerInfo);
     }
-    clearContainer(root.containerInfo);
   }
 
   let exitStatus;
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -86,7 +86,6 @@ import {
   cancelTimeout,
   noTimeout,
   afterActiveInstanceBlur,
-  clearContainer,
   getCurrentEventPriority,
   supportsMicrotasks,
   errorHydratingContainer,
@@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) {
     if (__DEV__) {
       errorHydratingContainer(root.containerInfo);
     }
-    clearContainer(root.containerInfo);
   }
 
   let exitStatus;

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,6 @@ import {`
`86`	`86`	`cancelTimeout,`
`87`	`87`	`noTimeout,`
`88`	`88`	`afterActiveInstanceBlur,`
`89`		`- clearContainer,`
`90`	`89`	`getCurrentEventPriority,`
`91`	`90`	`supportsMicrotasks,`
`92`	`91`	`errorHydratingContainer,`
`@@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) {`
`885`	`884`	`if (__DEV__) {`
`886`	`885`	`errorHydratingContainer(root.containerInfo);`
`887`	`886`	`}`
`888`		`- clearContainer(root.containerInfo);`
`889`	`887`	`}`
`890`	`888`
`891`	`889`	`let exitStatus;`