Skip to content

Commit a361701

Browse files
sebmarkbagesebmarkbage
committed
[Fiber/DevTools] Stop injecting findHostInstanceByFiber (#30519)
This is not used by DevTools since it has its own implementation of it. This function is getting removed since `findDOMNode` is getting removed so we shouldn't keep around extra bytes unnecessarily. There is also `findHostInstancesForRefresh` which should really be implemented on the `react-refresh` side. Not using an injection but that's a heavier lift and only affects `__DEV__`. DiffTrain build for commit bea5a2b.
1 parent aaac27a commit a361701

File tree

14 files changed

+62
-134
lines changed

14 files changed

+62
-134
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-6b82f3c9-20240729
1+
19.0.0-native-fb-bea5a2bc-20240729

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<45825b7fcc62c4e0270bf13c80f968b7>>
10+
* @generated SignedSource<<f86c05005971e3a7b71fb09889af7bf1>>
1111
*/
1212

1313
"use strict";
1414
__DEV__ &&
1515
(function () {
16-
function JSCompiler_object_inline_createNodeMock_1096() {
16+
function JSCompiler_object_inline_createNodeMock_1093() {
1717
return null;
1818
}
1919
function findHook(fiber, id) {
@@ -683,16 +683,6 @@ __DEV__ &&
683683
throw Error("Unable to find node on an unmounted component.");
684684
return a.stateNode.current === a ? fiber : alternate;
685685
}
686-
function findCurrentHostFiberImpl(node) {
687-
var tag = node.tag;
688-
if (5 === tag || 26 === tag || 27 === tag || 6 === tag) return node;
689-
for (node = node.child; null !== node; ) {
690-
tag = findCurrentHostFiberImpl(node);
691-
if (null !== tag) return tag;
692-
node = node.sibling;
693-
}
694-
return null;
695-
}
696686
function injectInternals(internals) {
697687
if ("undefined" === typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) return !1;
698688
var hook = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -12837,11 +12827,6 @@ __DEV__ &&
1283712827
(scheduleUpdateOnFiber(element, rootFiber, lane),
1283812828
entangleTransitions(element, rootFiber, lane));
1283912829
}
12840-
function findHostInstanceByFiber(fiber) {
12841-
fiber = findCurrentFiberUsingSlowPath(fiber);
12842-
fiber = null !== fiber ? findCurrentHostFiberImpl(fiber) : null;
12843-
return null === fiber ? null : fiber.stateNode;
12844-
}
1284512830
function emptyFindFiberByHostInstance() {
1284612831
return null;
1284712832
}
@@ -15109,7 +15094,6 @@ __DEV__ &&
1510915094
setSuspenseHandler: setSuspenseHandler,
1511015095
scheduleUpdate: scheduleUpdate,
1511115096
currentDispatcherRef: ReactSharedInternals,
15112-
findHostInstanceByFiber: findHostInstanceByFiber,
1511315097
findFiberByHostInstance:
1511415098
devToolsConfig.findFiberByHostInstance ||
1511515099
emptyFindFiberByHostInstance,
@@ -15118,20 +15102,20 @@ __DEV__ &&
1511815102
scheduleRoot: scheduleRoot,
1511915103
setRefreshHandler: setRefreshHandler,
1512015104
getCurrentFiber: getCurrentFiberForDevTools,
15121-
reconcilerVersion: "19.0.0-native-fb-6b82f3c9-20240729"
15105+
reconcilerVersion: "19.0.0-native-fb-bea5a2bc-20240729"
1512215106
});
1512315107
})({
1512415108
findFiberByHostInstance: function () {
1512515109
throw Error("TestRenderer does not support findFiberByHostInstance()");
1512615110
},
1512715111
bundleType: 1,
15128-
version: "19.0.0-native-fb-6b82f3c9-20240729",
15112+
version: "19.0.0-native-fb-bea5a2bc-20240729",
1512915113
rendererPackageName: "react-test-renderer"
1513015114
});
1513115115
exports._Scheduler = Scheduler;
1513215116
exports.act = act;
1513315117
exports.create = function (element, options) {
15134-
var createNodeMock = JSCompiler_object_inline_createNodeMock_1096,
15118+
var createNodeMock = JSCompiler_object_inline_createNodeMock_1093,
1513515119
isConcurrent = !1,
1513615120
isStrictMode = !1;
1513715121
"object" === typeof options &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 16 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2fc5c3e33cfc73fcc2c11ad232d302ed>>
10+
* @generated SignedSource<<3b0950e1d465316145b94897bec0f920>>
1111
*/
1212

1313
"use strict";
@@ -448,16 +448,6 @@ function findCurrentFiberUsingSlowPath(fiber) {
448448
throw Error("Unable to find node on an unmounted component.");
449449
return a.stateNode.current === a ? fiber : alternate;
450450
}
451-
function findCurrentHostFiberImpl(node) {
452-
var tag = node.tag;
453-
if (5 === tag || 26 === tag || 27 === tag || 6 === tag) return node;
454-
for (node = node.child; null !== node; ) {
455-
tag = findCurrentHostFiberImpl(node);
456-
if (null !== tag) return tag;
457-
node = node.sibling;
458-
}
459-
return null;
460-
}
461451
var isArrayImpl = Array.isArray,
462452
scheduleCallback$3 = Scheduler$1.unstable_scheduleCallback,
463453
cancelCallback$1 = Scheduler$1.unstable_cancelCallback,
@@ -9323,19 +9313,19 @@ function wrapFiber(fiber) {
93239313
fiberToWrapper.set(fiber, wrapper));
93249314
return wrapper;
93259315
}
9326-
var devToolsConfig$jscomp$inline_1035 = {
9316+
var devToolsConfig$jscomp$inline_1031 = {
93279317
findFiberByHostInstance: function () {
93289318
throw Error("TestRenderer does not support findFiberByHostInstance()");
93299319
},
93309320
bundleType: 0,
9331-
version: "19.0.0-native-fb-6b82f3c9-20240729",
9321+
version: "19.0.0-native-fb-bea5a2bc-20240729",
93329322
rendererPackageName: "react-test-renderer"
93339323
};
9334-
var internals$jscomp$inline_1211 = {
9335-
bundleType: devToolsConfig$jscomp$inline_1035.bundleType,
9336-
version: devToolsConfig$jscomp$inline_1035.version,
9337-
rendererPackageName: devToolsConfig$jscomp$inline_1035.rendererPackageName,
9338-
rendererConfig: devToolsConfig$jscomp$inline_1035.rendererConfig,
9324+
var internals$jscomp$inline_1207 = {
9325+
bundleType: devToolsConfig$jscomp$inline_1031.bundleType,
9326+
version: devToolsConfig$jscomp$inline_1031.version,
9327+
rendererPackageName: devToolsConfig$jscomp$inline_1031.rendererPackageName,
9328+
rendererConfig: devToolsConfig$jscomp$inline_1031.rendererConfig,
93399329
overrideHookState: null,
93409330
overrideHookStateDeletePath: null,
93419331
overrideHookStateRenamePath: null,
@@ -9346,32 +9336,27 @@ var internals$jscomp$inline_1211 = {
93469336
setSuspenseHandler: null,
93479337
scheduleUpdate: null,
93489338
currentDispatcherRef: ReactSharedInternals,
9349-
findHostInstanceByFiber: function (fiber) {
9350-
fiber = findCurrentFiberUsingSlowPath(fiber);
9351-
fiber = null !== fiber ? findCurrentHostFiberImpl(fiber) : null;
9352-
return null === fiber ? null : fiber.stateNode;
9353-
},
93549339
findFiberByHostInstance:
9355-
devToolsConfig$jscomp$inline_1035.findFiberByHostInstance ||
9340+
devToolsConfig$jscomp$inline_1031.findFiberByHostInstance ||
93569341
emptyFindFiberByHostInstance,
93579342
findHostInstancesForRefresh: null,
93589343
scheduleRefresh: null,
93599344
scheduleRoot: null,
93609345
setRefreshHandler: null,
93619346
getCurrentFiber: null,
9362-
reconcilerVersion: "19.0.0-native-fb-6b82f3c9-20240729"
9347+
reconcilerVersion: "19.0.0-native-fb-bea5a2bc-20240729"
93639348
};
93649349
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
9365-
var hook$jscomp$inline_1212 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
9350+
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
93669351
if (
9367-
!hook$jscomp$inline_1212.isDisabled &&
9368-
hook$jscomp$inline_1212.supportsFiber
9352+
!hook$jscomp$inline_1208.isDisabled &&
9353+
hook$jscomp$inline_1208.supportsFiber
93699354
)
93709355
try {
9371-
(rendererID = hook$jscomp$inline_1212.inject(
9372-
internals$jscomp$inline_1211
9356+
(rendererID = hook$jscomp$inline_1208.inject(
9357+
internals$jscomp$inline_1207
93739358
)),
9374-
(injectedHook = hook$jscomp$inline_1212);
9359+
(injectedHook = hook$jscomp$inline_1208);
93759360
} catch (err) {}
93769361
}
93779362
exports._Scheduler = Scheduler;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ebdb7058bb4b6e0370bac7651360c216>>
10+
* @generated SignedSource<<d632c5265089eef1357fa59e74d227eb>>
1111
*/
1212

1313
"use strict";
@@ -448,16 +448,6 @@ function findCurrentFiberUsingSlowPath(fiber) {
448448
throw Error("Unable to find node on an unmounted component.");
449449
return a.stateNode.current === a ? fiber : alternate;
450450
}
451-
function findCurrentHostFiberImpl(node) {
452-
var tag = node.tag;
453-
if (5 === tag || 26 === tag || 27 === tag || 6 === tag) return node;
454-
for (node = node.child; null !== node; ) {
455-
tag = findCurrentHostFiberImpl(node);
456-
if (null !== tag) return tag;
457-
node = node.sibling;
458-
}
459-
return null;
460-
}
461451
var isArrayImpl = Array.isArray,
462452
scheduleCallback$3 = Scheduler$1.unstable_scheduleCallback,
463453
cancelCallback$1 = Scheduler$1.unstable_cancelCallback,
@@ -9947,12 +9937,12 @@ function wrapFiber(fiber) {
99479937
fiberToWrapper.set(fiber, wrapper));
99489938
return wrapper;
99499939
}
9950-
var devToolsConfig$jscomp$inline_1119 = {
9940+
var devToolsConfig$jscomp$inline_1115 = {
99519941
findFiberByHostInstance: function () {
99529942
throw Error("TestRenderer does not support findFiberByHostInstance()");
99539943
},
99549944
bundleType: 0,
9955-
version: "19.0.0-native-fb-6b82f3c9-20240729",
9945+
version: "19.0.0-native-fb-bea5a2bc-20240729",
99569946
rendererPackageName: "react-test-renderer"
99579947
};
99589948
(function (internals) {
@@ -9969,10 +9959,10 @@ var devToolsConfig$jscomp$inline_1119 = {
99699959
} catch (err) {}
99709960
return hook.checkDCE ? !0 : !1;
99719961
})({
9972-
bundleType: devToolsConfig$jscomp$inline_1119.bundleType,
9973-
version: devToolsConfig$jscomp$inline_1119.version,
9974-
rendererPackageName: devToolsConfig$jscomp$inline_1119.rendererPackageName,
9975-
rendererConfig: devToolsConfig$jscomp$inline_1119.rendererConfig,
9962+
bundleType: devToolsConfig$jscomp$inline_1115.bundleType,
9963+
version: devToolsConfig$jscomp$inline_1115.version,
9964+
rendererPackageName: devToolsConfig$jscomp$inline_1115.rendererPackageName,
9965+
rendererConfig: devToolsConfig$jscomp$inline_1115.rendererConfig,
99769966
overrideHookState: null,
99779967
overrideHookStateDeletePath: null,
99789968
overrideHookStateRenamePath: null,
@@ -9983,20 +9973,15 @@ var devToolsConfig$jscomp$inline_1119 = {
99839973
setSuspenseHandler: null,
99849974
scheduleUpdate: null,
99859975
currentDispatcherRef: ReactSharedInternals,
9986-
findHostInstanceByFiber: function (fiber) {
9987-
fiber = findCurrentFiberUsingSlowPath(fiber);
9988-
fiber = null !== fiber ? findCurrentHostFiberImpl(fiber) : null;
9989-
return null === fiber ? null : fiber.stateNode;
9990-
},
99919976
findFiberByHostInstance:
9992-
devToolsConfig$jscomp$inline_1119.findFiberByHostInstance ||
9977+
devToolsConfig$jscomp$inline_1115.findFiberByHostInstance ||
99939978
emptyFindFiberByHostInstance,
99949979
findHostInstancesForRefresh: null,
99959980
scheduleRefresh: null,
99969981
scheduleRoot: null,
99979982
setRefreshHandler: null,
99989983
getCurrentFiber: null,
9999-
reconcilerVersion: "19.0.0-native-fb-6b82f3c9-20240729"
9984+
reconcilerVersion: "19.0.0-native-fb-bea5a2bc-20240729"
100009985
});
100019986
exports._Scheduler = Scheduler;
100029987
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b9e9e19d4032616fef667d0dd9eba802>>
10+
* @generated SignedSource<<ce9a60542404b5391a0325717aa14a30>>
1111
*/
1212

1313
"use strict";
@@ -1704,7 +1704,7 @@ __DEV__ &&
17041704
exports.useTransition = function () {
17051705
return resolveDispatcher().useTransition();
17061706
};
1707-
exports.version = "19.0.0-native-fb-6b82f3c9-20240729";
1707+
exports.version = "19.0.0-native-fb-bea5a2bc-20240729";
17081708
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17091709
"function" ===
17101710
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1b13935c9752f67504f31fedf1f97d68>>
10+
* @generated SignedSource<<fb41549baba1e6f16f81f36add5627f8>>
1111
*/
1212

1313
"use strict";
@@ -579,4 +579,4 @@ exports.useSyncExternalStore = function (
579579
exports.useTransition = function () {
580580
return ReactSharedInternals.H.useTransition();
581581
};
582-
exports.version = "19.0.0-native-fb-6b82f3c9-20240729";
582+
exports.version = "19.0.0-native-fb-bea5a2bc-20240729";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<51f1f5d0a03158aef8a5b651d1d06957>>
10+
* @generated SignedSource<<e54554c9f097565369f1b4ae58864a9d>>
1111
*/
1212

1313
"use strict";
@@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
583583
exports.useTransition = function () {
584584
return ReactSharedInternals.H.useTransition();
585585
};
586-
exports.version = "19.0.0-native-fb-6b82f3c9-20240729";
586+
exports.version = "19.0.0-native-fb-bea5a2bc-20240729";
587587
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
588588
"function" ===
589589
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
6b82f3c9048ff0dd7e6d628dc5770faf85d32a87
1+
bea5a2bc46cc95713392175c3c6307e49c14cd98

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<21e82ca5963e783e2f6590a40ce8119e>>
10+
* @generated SignedSource<<890a4ea59cd9164f3a5525dce24215bb>>
1111
*/
1212

1313
"use strict";
@@ -13898,10 +13898,6 @@ __DEV__ &&
1389813898
(scheduleUpdateOnFiber(element, rootFiber, lane),
1389913899
entangleTransitions(element, rootFiber, lane));
1390013900
}
13901-
function findHostInstanceByFiber(fiber) {
13902-
fiber = findCurrentHostFiber(fiber);
13903-
return null === fiber ? null : fiber.stateNode;
13904-
}
1390513901
function emptyFindFiberByHostInstance() {
1390613902
return null;
1390713903
}
@@ -16751,7 +16747,6 @@ __DEV__ &&
1675116747
setSuspenseHandler: setSuspenseHandler,
1675216748
scheduleUpdate: scheduleUpdate,
1675316749
currentDispatcherRef: ReactSharedInternals,
16754-
findHostInstanceByFiber: findHostInstanceByFiber,
1675516750
findFiberByHostInstance:
1675616751
devToolsConfig.findFiberByHostInstance ||
1675716752
emptyFindFiberByHostInstance,
@@ -16760,12 +16755,12 @@ __DEV__ &&
1676016755
scheduleRoot: scheduleRoot,
1676116756
setRefreshHandler: setRefreshHandler,
1676216757
getCurrentFiber: getCurrentFiberForDevTools,
16763-
reconcilerVersion: "19.0.0-native-fb-6b82f3c9-20240729"
16758+
reconcilerVersion: "19.0.0-native-fb-bea5a2bc-20240729"
1676416759
});
1676516760
})({
1676616761
findFiberByHostInstance: getInstanceFromNode,
1676716762
bundleType: 1,
16768-
version: "19.0.0-native-fb-6b82f3c9-20240729",
16763+
version: "19.0.0-native-fb-bea5a2bc-20240729",
1676916764
rendererPackageName: "react-native-renderer",
1677016765
rendererConfig: {
1677116766
getInspectorDataForInstance: getInspectorDataForInstance,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<51e1e1f2137d9e8f948aa81cc451048c>>
10+
* @generated SignedSource<<bbb0cad9b4b4944ddd2e3c424d4127e4>>
1111
*/
1212

1313
"use strict";
@@ -10576,7 +10576,7 @@ var roots = new Map(),
1057610576
devToolsConfig$jscomp$inline_1141 = {
1057710577
findFiberByHostInstance: getInstanceFromNode,
1057810578
bundleType: 0,
10579-
version: "19.0.0-native-fb-6b82f3c9-20240729",
10579+
version: "19.0.0-native-fb-bea5a2bc-20240729",
1058010580
rendererPackageName: "react-native-renderer",
1058110581
rendererConfig: {
1058210582
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10607,10 +10607,6 @@ var internals$jscomp$inline_1364 = {
1060710607
setSuspenseHandler: null,
1060810608
scheduleUpdate: null,
1060910609
currentDispatcherRef: ReactSharedInternals,
10610-
findHostInstanceByFiber: function (fiber) {
10611-
fiber = findCurrentHostFiber(fiber);
10612-
return null === fiber ? null : fiber.stateNode;
10613-
},
1061410610
findFiberByHostInstance:
1061510611
devToolsConfig$jscomp$inline_1141.findFiberByHostInstance ||
1061610612
emptyFindFiberByHostInstance,
@@ -10619,7 +10615,7 @@ var internals$jscomp$inline_1364 = {
1061910615
scheduleRoot: null,
1062010616
setRefreshHandler: null,
1062110617
getCurrentFiber: null,
10622-
reconcilerVersion: "19.0.0-native-fb-6b82f3c9-20240729"
10618+
reconcilerVersion: "19.0.0-native-fb-bea5a2bc-20240729"
1062310619
};
1062410620
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1062510621
var hook$jscomp$inline_1365 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)