Skip to content

Commit 66108fa

Browse files
rubennorterubennorte
committed
[RN] Move definition of public instances to ReactNativePrivateInterface (#32446)
## Summary > [!NOTE] > This only modifies types, so shouldn't have an impact at runtime. Some time ago we moved some type definitions from React to React Native in #26437. This continues making progress on that so values that are created by React Native and passed to the React renderer (in this case public instances) are actually defined in React Native and not in React. This will allow us to modify the definition of some of these types without having to make changes in the React repository (in the short term, we want to refactor PublicInstance from an object to an interface, and then modify that interface to add all the new DOM methods). ## How did you test this change? Manually synced `ReactNativeTypes` on top of facebook/react-native#49602 and verified Flow passes. DiffTrain build for [9dd378f](9dd378f)
1 parent 0cf3a7f commit 66108fa

24 files changed

+104
-164
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.1.0-native-fb-70f1d766-20250220
1+
19.1.0-native-fb-9dd378ff-20250224

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f1ed5ad5b371cc0a68ed181603f90916>>
10+
* @generated SignedSource<<9728716abd8fa7a6ba3e5f85b797037c>>
1111
*/
1212

1313
"use strict";
@@ -428,5 +428,5 @@ __DEV__ &&
428428
exports.useFormStatus = function () {
429429
return resolveDispatcher().useHostTransitionStatus();
430430
};
431-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
431+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";
432432
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<72d3f704544d715864166ac4b1c75da0>>
10+
* @generated SignedSource<<da4d0d3c078718fce227ac463d401f6d>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
206+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<72d3f704544d715864166ac4b1c75da0>>
10+
* @generated SignedSource<<da4d0d3c078718fce227ac463d401f6d>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
206+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<48efca5064ee325a05be1b5fbdf0be7a>>
10+
* @generated SignedSource<<1bfdabbd828a9bc24d21d9b93dbb6ae5>>
1111
*/
1212

1313
/*
@@ -25966,11 +25966,11 @@ __DEV__ &&
2596625966
};
2596725967
(function () {
2596825968
var isomorphicReactPackageVersion = React.version;
25969-
if ("19.1.0-native-fb-70f1d766-20250220" !== isomorphicReactPackageVersion)
25969+
if ("19.1.0-native-fb-9dd378ff-20250224" !== isomorphicReactPackageVersion)
2597025970
throw Error(
2597125971
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2597225972
(isomorphicReactPackageVersion +
25973-
"\n - react-dom: 19.1.0-native-fb-70f1d766-20250220\nLearn more: https://react.dev/warnings/version-mismatch")
25973+
"\n - react-dom: 19.1.0-native-fb-9dd378ff-20250224\nLearn more: https://react.dev/warnings/version-mismatch")
2597425974
);
2597525975
})();
2597625976
("function" === typeof Map &&
@@ -26007,10 +26007,10 @@ __DEV__ &&
2600726007
!(function () {
2600826008
var internals = {
2600926009
bundleType: 1,
26010-
version: "19.1.0-native-fb-70f1d766-20250220",
26010+
version: "19.1.0-native-fb-9dd378ff-20250224",
2601126011
rendererPackageName: "react-dom",
2601226012
currentDispatcherRef: ReactSharedInternals,
26013-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220"
26013+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224"
2601426014
};
2601526015
internals.overrideHookState = overrideHookState;
2601626016
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26154,5 +26154,5 @@ __DEV__ &&
2615426154
listenToAllSupportedEvents(container);
2615526155
return new ReactDOMHydrationRoot(initialChildren);
2615626156
};
26157-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
26157+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";
2615826158
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c44047ca782aca9e0243330cff9c91c7>>
10+
* @generated SignedSource<<9737a70fcef115b0bdca20ba8074742a>>
1111
*/
1212

1313
/*
@@ -16001,14 +16001,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1600116001
};
1600216002
var isomorphicReactPackageVersion$jscomp$inline_1785 = React.version;
1600316003
if (
16004-
"19.1.0-native-fb-70f1d766-20250220" !==
16004+
"19.1.0-native-fb-9dd378ff-20250224" !==
1600516005
isomorphicReactPackageVersion$jscomp$inline_1785
1600616006
)
1600716007
throw Error(
1600816008
formatProdErrorMessage(
1600916009
527,
1601016010
isomorphicReactPackageVersion$jscomp$inline_1785,
16011-
"19.1.0-native-fb-70f1d766-20250220"
16011+
"19.1.0-native-fb-9dd378ff-20250224"
1601216012
)
1601316013
);
1601416014
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16030,10 +16030,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1603016030
};
1603116031
var internals$jscomp$inline_2245 = {
1603216032
bundleType: 0,
16033-
version: "19.1.0-native-fb-70f1d766-20250220",
16033+
version: "19.1.0-native-fb-9dd378ff-20250224",
1603416034
rendererPackageName: "react-dom",
1603516035
currentDispatcherRef: ReactSharedInternals,
16036-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220"
16036+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224"
1603716037
};
1603816038
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1603916039
var hook$jscomp$inline_2246 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16137,4 +16137,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1613716137
listenToAllSupportedEvents(container);
1613816138
return new ReactDOMHydrationRoot(initialChildren);
1613916139
};
16140-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
16140+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1e6e9e4ccb7333f635f86d3a0b383ed1>>
10+
* @generated SignedSource<<709950585035b69d98367df2135ee568>>
1111
*/
1212

1313
/*
@@ -16651,14 +16651,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1665116651
};
1665216652
var isomorphicReactPackageVersion$jscomp$inline_1880 = React.version;
1665316653
if (
16654-
"19.1.0-native-fb-70f1d766-20250220" !==
16654+
"19.1.0-native-fb-9dd378ff-20250224" !==
1665516655
isomorphicReactPackageVersion$jscomp$inline_1880
1665616656
)
1665716657
throw Error(
1665816658
formatProdErrorMessage(
1665916659
527,
1666016660
isomorphicReactPackageVersion$jscomp$inline_1880,
16661-
"19.1.0-native-fb-70f1d766-20250220"
16661+
"19.1.0-native-fb-9dd378ff-20250224"
1666216662
)
1666316663
);
1666416664
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16680,10 +16680,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1668016680
};
1668116681
var internals$jscomp$inline_1887 = {
1668216682
bundleType: 0,
16683-
version: "19.1.0-native-fb-70f1d766-20250220",
16683+
version: "19.1.0-native-fb-9dd378ff-20250224",
1668416684
rendererPackageName: "react-dom",
1668516685
currentDispatcherRef: ReactSharedInternals,
16686-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220",
16686+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224",
1668716687
getLaneLabelMap: function () {
1668816688
for (
1668916689
var map = new Map(), lane = 1, index$294 = 0;
@@ -16802,4 +16802,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1680216802
listenToAllSupportedEvents(container);
1680316803
return new ReactDOMHydrationRoot(initialChildren);
1680416804
};
16805-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
16805+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<471066554e17e344ada305ba7169bac5>>
10+
* @generated SignedSource<<3799d5a81866bf08d1621dbb0d990782>>
1111
*/
1212

1313
/*
@@ -26027,11 +26027,11 @@ __DEV__ &&
2602726027
};
2602826028
(function () {
2602926029
var isomorphicReactPackageVersion = React.version;
26030-
if ("19.1.0-native-fb-70f1d766-20250220" !== isomorphicReactPackageVersion)
26030+
if ("19.1.0-native-fb-9dd378ff-20250224" !== isomorphicReactPackageVersion)
2603126031
throw Error(
2603226032
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2603326033
(isomorphicReactPackageVersion +
26034-
"\n - react-dom: 19.1.0-native-fb-70f1d766-20250220\nLearn more: https://react.dev/warnings/version-mismatch")
26034+
"\n - react-dom: 19.1.0-native-fb-9dd378ff-20250224\nLearn more: https://react.dev/warnings/version-mismatch")
2603526035
);
2603626036
})();
2603726037
("function" === typeof Map &&
@@ -26068,10 +26068,10 @@ __DEV__ &&
2606826068
!(function () {
2606926069
var internals = {
2607026070
bundleType: 1,
26071-
version: "19.1.0-native-fb-70f1d766-20250220",
26071+
version: "19.1.0-native-fb-9dd378ff-20250224",
2607226072
rendererPackageName: "react-dom",
2607326073
currentDispatcherRef: ReactSharedInternals,
26074-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220"
26074+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224"
2607526075
};
2607626076
internals.overrideHookState = overrideHookState;
2607726077
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26531,7 +26531,7 @@ __DEV__ &&
2653126531
exports.useFormStatus = function () {
2653226532
return resolveDispatcher().useHostTransitionStatus();
2653326533
};
26534-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
26534+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";
2653526535
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2653626536
"function" ===
2653726537
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<fd383d17c530517d8579fcf2307ddeb0>>
10+
* @generated SignedSource<<310bc00b2161d032fd2e88ce8d8a102c>>
1111
*/
1212

1313
/*
@@ -16012,14 +16012,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1601216012
};
1601316013
var isomorphicReactPackageVersion$jscomp$inline_1786 = React.version;
1601416014
if (
16015-
"19.1.0-native-fb-70f1d766-20250220" !==
16015+
"19.1.0-native-fb-9dd378ff-20250224" !==
1601616016
isomorphicReactPackageVersion$jscomp$inline_1786
1601716017
)
1601816018
throw Error(
1601916019
formatProdErrorMessage(
1602016020
527,
1602116021
isomorphicReactPackageVersion$jscomp$inline_1786,
16022-
"19.1.0-native-fb-70f1d766-20250220"
16022+
"19.1.0-native-fb-9dd378ff-20250224"
1602316023
)
1602416024
);
1602516025
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16041,10 +16041,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1604116041
};
1604216042
var internals$jscomp$inline_2248 = {
1604316043
bundleType: 0,
16044-
version: "19.1.0-native-fb-70f1d766-20250220",
16044+
version: "19.1.0-native-fb-9dd378ff-20250224",
1604516045
rendererPackageName: "react-dom",
1604616046
currentDispatcherRef: ReactSharedInternals,
16047-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220"
16047+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224"
1604816048
};
1604916049
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1605016050
var hook$jscomp$inline_2249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16302,4 +16302,4 @@ exports.useFormState = function (action, initialState, permalink) {
1630216302
exports.useFormStatus = function () {
1630316303
return ReactSharedInternals.H.useHostTransitionStatus();
1630416304
};
16305-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
16305+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a9a3916225ae01d8d1b69b9cb1d6cebd>>
10+
* @generated SignedSource<<06e3fe06fe06317bfa4623933475eb73>>
1111
*/
1212

1313
/*
@@ -16666,14 +16666,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1666616666
};
1666716667
var isomorphicReactPackageVersion$jscomp$inline_1881 = React.version;
1666816668
if (
16669-
"19.1.0-native-fb-70f1d766-20250220" !==
16669+
"19.1.0-native-fb-9dd378ff-20250224" !==
1667016670
isomorphicReactPackageVersion$jscomp$inline_1881
1667116671
)
1667216672
throw Error(
1667316673
formatProdErrorMessage(
1667416674
527,
1667516675
isomorphicReactPackageVersion$jscomp$inline_1881,
16676-
"19.1.0-native-fb-70f1d766-20250220"
16676+
"19.1.0-native-fb-9dd378ff-20250224"
1667716677
)
1667816678
);
1667916679
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -16695,10 +16695,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1669516695
};
1669616696
var internals$jscomp$inline_1888 = {
1669716697
bundleType: 0,
16698-
version: "19.1.0-native-fb-70f1d766-20250220",
16698+
version: "19.1.0-native-fb-9dd378ff-20250224",
1669916699
rendererPackageName: "react-dom",
1670016700
currentDispatcherRef: ReactSharedInternals,
16701-
reconcilerVersion: "19.1.0-native-fb-70f1d766-20250220",
16701+
reconcilerVersion: "19.1.0-native-fb-9dd378ff-20250224",
1670216702
getLaneLabelMap: function () {
1670316703
for (
1670416704
var map = new Map(), lane = 1, index$294 = 0;
@@ -16971,7 +16971,7 @@ exports.useFormState = function (action, initialState, permalink) {
1697116971
exports.useFormStatus = function () {
1697216972
return ReactSharedInternals.H.useHostTransitionStatus();
1697316973
};
16974-
exports.version = "19.1.0-native-fb-70f1d766-20250220";
16974+
exports.version = "19.1.0-native-fb-9dd378ff-20250224";
1697516975
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1697616976
"function" ===
1697716977
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)