Run ReactFabric-test.internal.js in xplat variant

The explicit mock override in this test was causing it to always run as native-oss instead of also as xplat. This moves the test to use `// @gate persistent` instead to run it in all persistent configs.

Author: kassens

packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js

@@ -25,10 +25,6 @@ const SEND_ACCESSIBILITY_EVENT_REQUIRES_HOST_COMPONENT =
   "sendAccessibilityEvent was called with a ref that isn't a " +
   'native component. Use React.forwardRef to get access to the underlying native component';
 
-jest.mock('shared/ReactFeatureFlags', () =>
-  require('shared/forks/ReactFeatureFlags.native-oss'),
-);
-
 describe('ReactFabric', () => {
   beforeEach(() => {
     jest.resetModules();
@@ -45,6 +41,7 @@ describe('ReactFabric', () => {
     act = require('internal-test-utils').act;
   });
 
+  // @gate persistent
   it('should be able to create and render a native component', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -59,6 +56,7 @@ describe('ReactFabric', () => {
     expect(nativeFabricUIManager.completeRoot).toBeCalled();
   });
 
+  // @gate persistent
   it('should be able to create and update a native component', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -93,6 +91,7 @@ describe('ReactFabric', () => {
     });
   });
 
+  // @gate persistent
   it('should not call FabricUIManager.cloneNode after render for properties that have not changed', async () => {
     const Text = createReactNativeComponentClass('RCTText', () => ({
       validAttributes: {foo: true},
@@ -164,6 +163,7 @@ describe('ReactFabric', () => {
     ).toHaveBeenCalledTimes(1);
   });
 
+  // @gate persistent
   it('should only pass props diffs to FabricUIManager.cloneNode', async () => {
     const Text = createReactNativeComponentClass('RCTText', () => ({
       validAttributes: {foo: true, bar: true},
@@ -225,6 +225,7 @@ describe('ReactFabric', () => {
     ).toMatchSnapshot();
   });
 
+  // @gate persistent
   it('should not clone nodes without children when updating props', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -273,6 +274,7 @@ describe('ReactFabric', () => {
     expect(nativeFabricUIManager.completeRoot).toBeCalled();
   });
 
+  // @gate persistent
   it('should call dispatchCommand for native refs', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -303,6 +305,7 @@ describe('ReactFabric', () => {
     );
   });
 
+  // @gate persistent
   it('should warn and no-op if calling dispatchCommand on non native refs', async () => {
     class BasicClass extends React.Component {
       render() {
@@ -334,6 +337,7 @@ describe('ReactFabric', () => {
     expect(nativeFabricUIManager.dispatchCommand).not.toBeCalled();
   });
 
+  // @gate persistent
   it('should call sendAccessibilityEvent for native refs', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -365,6 +369,7 @@ describe('ReactFabric', () => {
     );
   });
 
+  // @gate persistent
   it('should warn and no-op if calling sendAccessibilityEvent on non native refs', async () => {
     class BasicClass extends React.Component {
       render() {
@@ -396,6 +401,7 @@ describe('ReactFabric', () => {
     expect(nativeFabricUIManager.sendAccessibilityEvent).not.toBeCalled();
   });
 
+  // @gate persistent
   it('returns the correct instance and calls it in the callback', () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -417,6 +423,7 @@ describe('ReactFabric', () => {
     expect(a).toBe(c);
   });
 
+  // @gate persistent
   it('renders and reorders children', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {title: true},
@@ -425,6 +432,7 @@ describe('ReactFabric', () => {
 
     class Component extends React.Component {
       render() {
+        // @gate persistent
         const chars = this.props.chars.split('');
         return (
           <View>
@@ -455,6 +463,7 @@ describe('ReactFabric', () => {
     ).toMatchSnapshot();
   });
 
+  // @gate persistent
   it('recreates host parents even if only children changed', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {title: true},
@@ -469,6 +478,7 @@ describe('ReactFabric', () => {
         chars: before,
       };
       render() {
+        // @gate persistent
         const chars = this.state.chars.split('');
         return (
           <View>
@@ -504,6 +514,7 @@ describe('ReactFabric', () => {
     ).toMatchSnapshot();
   });
 
+  // @gate persistent
   it('calls setState with no arguments', async () => {
     let mockArgs;
     class Component extends React.Component {
@@ -521,6 +532,7 @@ describe('ReactFabric', () => {
     expect(mockArgs.length).toEqual(0);
   });
 
+  // @gate persistent
   it('should call complete after inserting children', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -547,6 +559,7 @@ describe('ReactFabric', () => {
     expect(snapshots).toMatchSnapshot();
   });
 
+  // @gate persistent
   it('should not throw when <View> is used inside of a <Text> ancestor', async () => {
     const Image = createReactNativeComponentClass('RCTImage', () => ({
       validAttributes: {},
@@ -580,6 +593,7 @@ describe('ReactFabric', () => {
     });
   });
 
+  // @gate persistent
   it('should console error for text not inside of a <Text> ancestor', async () => {
     const ScrollView = createReactNativeComponentClass('RCTScrollView', () => ({
       validAttributes: {},
@@ -612,6 +626,7 @@ describe('ReactFabric', () => {
     }).toErrorDev(['Text strings must be rendered within a <Text> component.']);
   });
 
+  // @gate persistent
   it('should not throw for text inside of an indirect <Text> ancestor', async () => {
     const Text = createReactNativeComponentClass('RCTText', () => ({
       validAttributes: {},
@@ -630,6 +645,7 @@ describe('ReactFabric', () => {
     });
   });
 
+  // @gate persistent
   it('dispatches events to the last committed props', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {},
@@ -684,6 +700,7 @@ describe('ReactFabric', () => {
   });
 
   describe('skipBubbling', () => {
+    // @gate persistent
     it('should skip bubbling to ancestor if specified', async () => {
       const View = createReactNativeComponentClass('RCTView', () => ({
         validAttributes: {},
@@ -777,6 +794,7 @@ describe('ReactFabric', () => {
     });
   });
 
+  // @gate persistent
   it('dispatches event with target as instance', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {
@@ -868,6 +886,7 @@ describe('ReactFabric', () => {
     expect.assertions(6);
   });
 
+  // @gate persistent
   it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -909,6 +928,7 @@ describe('ReactFabric', () => {
     expect(match).toBe(child);
   });
 
+  // @gate persistent
   it('findHostInstance_DEPRECATED should warn if passed a component that is inside StrictMode', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -948,6 +968,7 @@ describe('ReactFabric', () => {
     expect(match).toBe(child);
   });
 
+  // @gate persistent
   it('findNodeHandle should warn if used to find a host component inside StrictMode', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -989,6 +1010,7 @@ describe('ReactFabric', () => {
     );
   });
 
+  // @gate persistent
   it('findNodeHandle should warn if passed a component that is inside StrictMode', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -1028,6 +1050,7 @@ describe('ReactFabric', () => {
     );
   });
 
+  // @gate persistent
   it('should no-op if calling sendAccessibilityEvent on unmounted refs', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -1060,6 +1083,7 @@ describe('ReactFabric', () => {
     expect(nativeFabricUIManager.sendAccessibilityEvent).not.toBeCalled();
   });
 
+  // @gate persistent
   it('getNodeFromInternalInstanceHandle should return the correct shadow node', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -1084,6 +1108,7 @@ describe('ReactFabric', () => {
     expect(node).toBe(expectedShadowNode);
   });
 
+  // @gate persistent
   it('getPublicInstanceFromInternalInstanceHandle should provide public instances for HostComponent', async () => {
     const View = createReactNativeComponentClass('RCTView', () => ({
       validAttributes: {foo: true},
@@ -1124,6 +1149,7 @@ describe('ReactFabric', () => {
     expect(publicInstanceAfterUnmount).toBe(null);
   });
 
+  // @gate persistent
   it('getPublicInstanceFromInternalInstanceHandle should provide public instances for HostText', async () => {
     jest.spyOn(ReactNativePrivateInterface, 'createPublicTextInstance');