Add module name constant to class for downstream use #38295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47095993 |
rbergerjr
added a commit
to rbergerjr/react-native
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Differential Revision: D47095993 fbshipit-source-id: d5b2cb53e81df0dfc1e64baa69c85e557cbc7ac2
rbergerjr
force-pushed
the
export-D47095993
branch
from
cab2892 to
b3052a5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47095993 |
rbergerjr
added a commit
to rbergerjr/react-native
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Differential Revision: D47095993 fbshipit-source-id: 629370ae7864e6b69d46e189ea7ac7b734ffa677
rbergerjr
force-pushed
the
export-D47095993
branch
from
b3052a5 to
fa6b478
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47095993 |
Base commit: 5ba8de0 |
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Reviewed By: christophpurrer Differential Revision: D47095993 fbshipit-source-id: d163f0d4e460cb41f3b3700727eb5c9c5d66b205
rbergerjr
force-pushed
the
export-D47095993
branch
from
fa6b478 to
6489a75
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D47095993 |
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Differential Revision: https://www.internalfb.com/diff/D47095993?entry_point=27 fbshipit-source-id: dfa0655dee5428e81063b9ef755d0fac7d3735e3
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
Summary: Continuation of facebook#38295 Changelog: [Internal] [Changed] - rn-tester > Use code-generate Turbo Module constants Differential Revision: D47376344 fbshipit-source-id: c84010ae697e07379ac1fcd476828db362afb76e
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Differential Revision: https://www.internalfb.com/diff/D47095993?entry_point=27 fbshipit-source-id: 1e09238274ae38dca5873a73515eb98633fbcb85
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
Summary: Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Differential Revision: D47376344 fbshipit-source-id: 9edd650257cbf38070ee2493320b4941d07dc1d0
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
Summary: Pull Request resolved: facebook#38295 Move constant to class instance so customers can use strongly typed name, feedback from D46159001 Changelog: [Internal] [Changed] - Add module name constant to codegen'd class for downstream use Differential Revision: https://www.internalfb.com/diff/D47095993?entry_point=27 fbshipit-source-id: e00b4bd8e2262a476205828f9b110e235c15792f
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
…38297) Summary: Pull Request resolved: facebook#38297 Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Differential Revision: D47376344 fbshipit-source-id: 1257cc396af6b0f48b8a6e0974af37472d48001a
Contributor
|
This pull request has been merged in f396067. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
…38297) Summary: Pull Request resolved: facebook#38297 Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Reviewed By: shwanton Differential Revision: D47376344 fbshipit-source-id: b83d8519564c673c0e7f7d0c08c0a571350e9032
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
…38297) Summary: Pull Request resolved: facebook#38297 Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Reviewed By: shwanton Differential Revision: D47376344 fbshipit-source-id: 83d38df83789bdab17a3c772c7aad6db6891859e
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 11, 2023
…38297) Summary: Pull Request resolved: facebook#38297 Continuation of facebook#38295 Changelog: [Internal] [Changed] - Use code-generated Turbo Module name constants Reviewed By: shwanton Differential Revision: D47376344 fbshipit-source-id: 627bd0f075660173bf087cb50d6ed770d66e9f32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Move constant to class instance so customers can use strongly typed name, feedback from D46159001
Changelog:
[Internal] [Changed] - Add module name constant to codegen'd class for downstream use
Differential Revision: D47095993