Skip to content

Conversation

@safaiyeh
Copy link
Contributor

@safaiyeh safaiyeh commented Oct 26, 2020

Summary

Came to learn RN is deprecating Android 19, 20: a17ff44

Did a quick check of left over code from the deprecation.

Changelog

[Android] [Deprecated] - Cleanup usages of deprecated Android API

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2020
@safaiyeh
Copy link
Contributor Author

cc @JoshuaGross if you could check this out

@safaiyeh
Copy link
Contributor Author

@fkgozali

@JoshuaGross
Copy link
Contributor

Cool! Thanks for doing this!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@dulmandakh dulmandakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @safaiyeh in dd4298a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 27, 2020
@safaiyeh safaiyeh deleted the android-deprecation-cleanup branch October 27, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Deprecation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants