Fix shellcheck warnings in Hermes build scripts

Summary:
Fixes some shellcheck warnings that arose in D36295406 (ae28880) when the Hermes build scripts were copied over.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D36321074

fbshipit-source-id: 0eae36a4f793daa0e12786ba7989d4eac6b2e256

Author: hramos

sdks/hermes-engine/utils/build-apple-framework.sh

@@ -90,9 +90,9 @@ function create_universal_framework {
   done
 
   mkdir universal
-  xcodebuild -create-xcframework $args -output "universal/hermes.xcframework"
+  xcodebuild -create-xcframework "$args" -output "universal/hermes.xcframework"
 
-  for platform in $@; do
+  for platform in "$@"; do
     rm -r "$platform"
   done
 

sdks/hermes-engine/utils/build-ios-framework.sh

@@ -4,6 +4,7 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
+# shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh
 . ./utils/build-apple-framework.sh
 
 if [ ! -d destroot/Library/Frameworks/universal/hermes.xcframework ]; then

sdks/hermes-engine/utils/build-mac-framework.sh

@@ -4,7 +4,9 @@
 # This source code is licensed under the MIT license found in the
 # LICENSE file in the root directory of this source tree.
 
+# shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh
 . ./utils/build-apple-framework.sh
+
 if [ ! -d destroot/Library/Frameworks/macosx/hermes.framework ]; then
     mac_deployment_target=$(get_mac_deployment_target)