Integration with mypy_primer?

[hauntsaninja]

Hello! Let me know if I can make https://github.com/hauntsaninja/mypy_primer useful for pyrefly

[MaggieMoss]

Hi! We would love to integrate into mypy_primer. What would be the best way to go about it? We can put up a PR and collaborate that way?

[hauntsaninja]

Yup! I also added a few lines on how to get set up here: https://github.com/hauntsaninja/mypy_primer#adding-support-for-a-new-type-checker

[yangdanny97]

Last week I got pyrefly working with mypy_primer in a fork at https://github.com/yangdanny97/mypy_primer, the basic behavior should be there but the per-project commands/configs need some changes.

If I opened a PR and we merged it now, would it affect the CI jobs for everyone that uses the primer? If so, we may want to wait till Pyrefly is more stable to reduce churn.

We're also running a version of mypy_primer in our internal CI, but it's an entirely new script that only reuses the per-project configs from the original mypy_primer. The main differences are that it uses mercurial instead of git, and it doesn't do a diff of before/after - it just runs once and logs the errors to a table for us to track the errors over time.

We'd like to run the regular version of mypy_primer in CI at some point though.

[hauntsaninja]

Sounds good! I think some of your diff would no longer be needed given some of my latest changes. See also hauntsaninja/mypy_primer#155

The pyrefly branches are self-contained, so it won't really affect other projects' jobs if it were to be merged, so happy to have it upstreamed now

Also happy to grant some of y'all commit access, in case that makes anything easier