From 8bd668a7251c4093069a567e6db51fa9f7b9d3a5 Mon Sep 17 00:00:00 2001 From: Justkant Date: Wed, 17 May 2017 13:44:21 +0200 Subject: [PATCH 1/2] Webpack config typo --- packages/react-scripts/config/webpack.config.dev.js | 4 ++-- packages/react-scripts/config/webpack.config.prod.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js index 3d198d28a34..87784f065fc 100644 --- a/packages/react-scripts/config/webpack.config.dev.js +++ b/packages/react-scripts/config/webpack.config.dev.js @@ -146,10 +146,10 @@ module.exports = { include: paths.appSrc, }, // ** ADDING/UPDATING LOADERS ** - // The "url" loader handles all assets unless explicitly excluded. + // The "file" loader handles all assets unless explicitly excluded. // The `exclude` list *must* be updated with every change to loader extensions. // When adding a new loader, you must add its `test` - // as a new entry in the `exclude` list for "url" loader. + // as a new entry in the `exclude` list for "file" loader. // "file" loader makes sure those assets get served by WebpackDevServer. // When you `import` an asset, you get its (virtual) filename. diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js index 9742e7ff50a..adb7ce3d4e5 100644 --- a/packages/react-scripts/config/webpack.config.prod.js +++ b/packages/react-scripts/config/webpack.config.prod.js @@ -145,10 +145,10 @@ module.exports = { include: paths.appSrc, }, // ** ADDING/UPDATING LOADERS ** - // The "url" loader handles all assets unless explicitly excluded. + // The "file" loader handles all assets unless explicitly excluded. // The `exclude` list *must* be updated with every change to loader extensions. // When adding a new loader, you must add its `test` - // as a new entry in the `exclude` list in the "url" loader. + // as a new entry in the `exclude` list in the "file" loader. // "file" loader makes sure those assets end up in the `build` folder. // When you `import` an asset, you get its filename. From 8396497ced920f596c44277231f582135cde5ce7 Mon Sep 17 00:00:00 2001 From: Justkant Date: Wed, 17 May 2017 14:08:43 +0200 Subject: [PATCH 2/2] Webpack config more typo --- packages/react-scripts/config/webpack.config.dev.js | 2 +- packages/react-scripts/config/webpack.config.prod.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js index 87784f065fc..540d54abf5c 100644 --- a/packages/react-scripts/config/webpack.config.dev.js +++ b/packages/react-scripts/config/webpack.config.dev.js @@ -233,7 +233,7 @@ module.exports = { ], }, // ** STOP ** Are you adding a new loader? - // Remember to add the new extension(s) to the "url" loader exclusion list. + // Remember to add the new extension(s) to the "file" loader exclusion list. ], }, plugins: [ diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js index adb7ce3d4e5..7df2af07baf 100644 --- a/packages/react-scripts/config/webpack.config.prod.js +++ b/packages/react-scripts/config/webpack.config.prod.js @@ -243,7 +243,7 @@ module.exports = { // Note: this won't work without `new ExtractTextPlugin()` in `plugins`. }, // ** STOP ** Are you adding a new loader? - // Remember to add the new extension(s) to the "url" loader exclusion list. + // Remember to add the new extension(s) to the "file" loader exclusion list. ], }, plugins: [