From 3069fc133d8132781a81629520ed4451e5131301 Mon Sep 17 00:00:00 2001 From: vic Date: Fri, 24 Mar 2017 16:41:55 +0530 Subject: [PATCH 1/2] Test that proxy url specified starts with http:// or https:// --- .../react-scripts/scripts/utils/addWebpackMiddleware.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/react-scripts/scripts/utils/addWebpackMiddleware.js b/packages/react-scripts/scripts/utils/addWebpackMiddleware.js index d2a97507237..3e6fa89aa78 100644 --- a/packages/react-scripts/scripts/utils/addWebpackMiddleware.js +++ b/packages/react-scripts/scripts/utils/addWebpackMiddleware.js @@ -89,6 +89,14 @@ module.exports = function addWebpackMiddleware(devServer) { ) ); process.exit(1); + // Test that proxy url specified starts with http:// or https:// + } else if (!/^http(s)?:\/\//.test(proxy)) { + console.log( + chalk.red( + 'When "proxy" in package.json is specified it must start with either http:// or https://' + ) + ); + process.exit(1); } // Otherwise, if proxy is specified, we will let it handle any request. From d2a16f638e91d6d0951d6904004a7e00ec0de85e Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 14 Apr 2017 22:48:24 -0400 Subject: [PATCH 2/2] Update addWebpackMiddleware.js --- packages/react-scripts/scripts/utils/addWebpackMiddleware.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/utils/addWebpackMiddleware.js b/packages/react-scripts/scripts/utils/addWebpackMiddleware.js index 3e6fa89aa78..e8c0fc5c1d1 100644 --- a/packages/react-scripts/scripts/utils/addWebpackMiddleware.js +++ b/packages/react-scripts/scripts/utils/addWebpackMiddleware.js @@ -93,7 +93,7 @@ module.exports = function addWebpackMiddleware(devServer) { } else if (!/^http(s)?:\/\//.test(proxy)) { console.log( chalk.red( - 'When "proxy" in package.json is specified it must start with either http:// or https://' + 'When "proxy" is specified in package.json it must start with either http:// or https://' ) ); process.exit(1);